Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 1116463002: [Chromoting] Add missing file to webapp's GN build. (Closed)

Created:
5 years, 7 months ago by garykac
Modified:
5 years, 7 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromoting] Add missing file to webapp's GN build. This also makes the Note at the top of the files (to keep the GYP and GN files in sync) a bit more noticeable. BUG= Committed: https://crrev.com/ed09d9afa925ba6bd4fe2fa8e705ad2cc2c60e73 Cr-Commit-Position: refs/heads/master@{#327378}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M remoting/remoting_webapp_files.gypi View 1 chunk +9 lines, -1 line 0 comments Download
M remoting/webapp/files.gni View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
garykac
5 years, 7 months ago (2015-04-28 20:25:40 UTC) #2
Jamie
lgtm
5 years, 7 months ago (2015-04-28 21:10:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116463002/1
5 years, 7 months ago (2015-04-28 21:12:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-28 22:28:22 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-28 22:29:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed09d9afa925ba6bd4fe2fa8e705ad2cc2c60e73
Cr-Commit-Position: refs/heads/master@{#327378}

Powered by Google App Engine
This is Rietveld 408576698