Avoid NPE when getCacheDir not available on renderer process.

Avoid NPE when getCacheDir not available on renderer process.

BUG=481965
Committed: https://crrev.com/f5e16ca669b193d696d5b90c9ff3515a89248412
Cr-Commit-Position: refs/heads/master@{#327485}

[Peter Wen, 2015-04-28 19:22:33]

wnwen@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Peter Wen, 2015-04-28 19:22:34]

Hi Yaron,

Do you think it's valuable to fix the crash and then look for a way to improve
renderer process initialization?

Seems understanding process initialization and fixing it will take a non-trivial
amount of time. Not sure if this crash is blocking other stuff.

Thanks,

Peter

[Yaron, 2015-04-28 21:55:18]

lgtm

This seems fine to unblock dev but I would like to fix it properly

https://codereview.chromium.org/1116433003/diff/1/base/android/java/src/org/c...
File base/android/java/src/org/chromium/base/PathUtils.java (right):

https://codereview.chromium.org/1116433003/diff/1/base/android/java/src/org/c...
base/android/java/src/org/chromium/base/PathUtils.java:47:
paths[CACHE_DIRECTORY] = appContext.getCacheDir().getPath();
I would just guard this one assignment.

[Peter Wen, 2015-04-29 13:11:08]

On 2015/04/28 21:55:18, Yaron wrote:
> lgtm
> 
> This seems fine to unblock dev but I would like to fix it properly
> 
>
https://codereview.chromium.org/1116433003/diff/1/base/android/java/src/org/c...
> File base/android/java/src/org/chromium/base/PathUtils.java (right):
> 
>
https://codereview.chromium.org/1116433003/diff/1/base/android/java/src/org/c...
> base/android/java/src/org/chromium/base/PathUtils.java:47:
> paths[CACHE_DIRECTORY] = appContext.getCacheDir().getPath();
> I would just guard this one assignment.

Will open a separate tracking bug for the refactor.

[Peter Wen, 2015-04-29 13:14:54]

The CQ bit was checked by wnwen@chromium.org

[Peter Wen, 2015-04-29 13:14:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org
Link to the patchset: https://codereview.chromium.org/1116433003/#ps20001
(title: "Only guard cachedir.")

[commit-bot: I haz the power, 2015-04-29 13:15:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116433003/20001

[commit-bot: I haz the power, 2015-04-29 14:04:33]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-29 14:05:52]

Patchset 2 (id:??) landed as
https://crrev.com/f5e16ca669b193d696d5b90c9ff3515a89248412
Cr-Commit-Position: refs/heads/master@{#327485}