Issue 111633004: [MIPS] Add support for Chromium-Android for MIPS build to BUILD.gn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 111633004: [MIPS] Add support for Chromium-Android for MIPS build to BUILD.gn (Closed)

Created:
6 years, 11 months ago by petarj

Modified:
6 years, 11 months ago

Reviewers:
brettw

CC:
chromium-reviews, gordana.cmiljanovic_imgtec.com

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[MIPS] Add support for Chromium-Android for MIPS build to BUILD.gn Fix build regressions for Chrome for Android for MIPS that came with r242674. BUG= gclient runhooks fails for MIPS TEST= build content_shell for Android MIPS Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242797

Patch Set 1 #

Patch Set 2 : Update tools/gn/variables.cc. #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
M	build/gyp_chromium	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	build/toolchain/android/BUILD.gn	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	tools/gn/variables.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

brettw

Can you also add "mipsel" to the documentation for this in tools/gn/variables.cc (search for kCpuArch)?

6 years, 11 months ago (2013-12-30 21:37:20 UTC) #2

petarj

On 2013/12/30 21:37:20, brettw wrote: > Can you also add "mipsel" to the documentation for ...

6 years, 11 months ago (2013-12-30 23:36:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/111633004/200001

6 years, 11 months ago (2013-12-31 00:27:26 UTC) #5

Message was sent while issue was closed.

Change committed as 242797

Expand Messages | Collapse Messages