runtime/lib/debugger.dart - Issue 1116263004: Add 'dart:debugger' library

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/lib/debugger.dart

Issue 1116263004: Add 'dart:debugger' library (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file	1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file

2 // for details. All rights reserved. Use of this source code is governed by a	2 // for details. All rights reserved. Use of this source code is governed by a

3 // BSD-style license that can be found in the LICENSE file.	3 // BSD-style license that can be found in the LICENSE file.

4	4

5 library test_lib2_foo;	5 import 'dart:_internal';

6	6

7 export 'test_lib2_bar.dart';	7 patch class Debugger {

8	8 /* patch */ static void breakpoint() native "Debugger_breakpoint";
	hausner 2015/05/05 00:16:26 Is this name dictated by some spec? I think a verb Is this name dictated by some spec? I think a verb would make more sense if you have the liberty to choose. Debugger.suspend() or Debugger.halt() or something is maybe more descriptive than Debugger.breakpoint(). Unfortunately, Debugger.break() doesn't work because break is a keyword. There is a bit of bikeshedding about this in dartbug.com/10536 Cutch 2015/05/05 02:38:53 I went with "breakHere" and "breakHereIf". Show quoted text On 2015/05/05 00:16:26, hausner wrote: > Is this name dictated by some spec? I think a verb would make more sense if you > have the liberty to choose. Debugger.suspend() or Debugger.halt() or something > is maybe more descriptive than Debugger.breakpoint(). > > Unfortunately, Debugger.break() doesn't work because break is a keyword. > > There is a bit of bikeshedding about this in dartbug.com/10536 I went with "breakHere" and "breakHereIf".
9 class Foo {

10

11 }	9 }

12

13 main() {

14 print('hello world');

15 }

OLD	NEW

« no previous file with comments | « runtime/lib/debugger.cc ('k') | runtime/lib/debugger_sources.gypi » ('j') | runtime/vm/debugger.cc » ('J')