Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1116263003: Remove unnecessary ScopedTrackers for what turned out to be IsGloballyReachable() jank. (Closed)

Created:
5 years, 7 months ago by eroman
Modified:
5 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary ScopedTrackers for what turned out to be IsGloballyReachable() jank. BUG=455942 Committed: https://crrev.com/2734a9dffc7cc616a3a6f962ccd7ae8116d20dfd Cr-Commit-Position: refs/heads/master@{#328377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M net/dns/host_resolver_impl.cc View 4 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
eroman
5 years, 7 months ago (2015-05-04 22:55:29 UTC) #2
mmenke
LGTM
5 years, 7 months ago (2015-05-05 14:54:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116263003/1
5 years, 7 months ago (2015-05-05 17:13:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 19:24:46 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 19:25:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2734a9dffc7cc616a3a6f962ccd7ae8116d20dfd
Cr-Commit-Position: refs/heads/master@{#328377}

Powered by Google App Engine
This is Rietveld 408576698