Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: chrome/installer/util/BUILD.gn

Issue 1116263002: Revert of Add installer_util_unittests to the GN windows build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@wintests3
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/installer/upgrade_test.gyp ('k') | chrome/installer/util/browser_distribution.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni")
6
7 static_library("util") { 5 static_library("util") {
8 deps = [ 6 deps = [
9 "//base", 7 "//base",
10 "//chrome:resources", 8 "//chrome:resources",
11 "//chrome:strings", 9 "//chrome:strings",
12 ] 10 ]
13 11
14 if (is_win) { 12 if (is_win) {
15 # TODO(GYP) installer_util on Windows. 13 # TODO(GYP) installer_util on Windows.
16 # This is a bit tricky. It seems that what's currently called 14 # This is a bit tricky. It seems that what's currently called
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 ":strings", 56 ":strings",
59 "//base/third_party/dynamic_annotations", 57 "//base/third_party/dynamic_annotations",
60 "//chrome/common:constants", 58 "//chrome/common:constants",
61 "//components/metrics", 59 "//components/metrics",
62 "//courgette:courgette_lib", 60 "//courgette:courgette_lib",
63 "//crypto", 61 "//crypto",
64 "//third_party/bspatch", 62 "//third_party/bspatch",
65 "//third_party/icu", 63 "//third_party/icu",
66 "//third_party/lzma_sdk", 64 "//third_party/lzma_sdk",
67 ] 65 ]
66 include_dirs = [ "$root_gen_dir/installer_util_strings" ]
68 67
69 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. 68 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
70 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ] 69 configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
71 70
72 # TODO(GYP) hook up corresponding version of installer_util_nacl_win64 in GN 71 # TODO(GYP) hook up corresponding version of installer_util_nacl_win64 in GN
73 sources += [ 72 sources += [
74 "advanced_firewall_manager_win.cc", 73 "advanced_firewall_manager_win.cc",
75 "advanced_firewall_manager_win.h", 74 "advanced_firewall_manager_win.h",
76 "app_command.cc", 75 "app_command.cc",
77 "app_command.h", 76 "app_command.h",
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 "google_update_experiment_util.cc", 161 "google_update_experiment_util.cc",
163 "google_update_experiment_util.h", 162 "google_update_experiment_util.h",
164 "master_preferences.cc", 163 "master_preferences.cc",
165 "master_preferences.h", 164 "master_preferences.h",
166 "master_preferences_constants.cc", 165 "master_preferences_constants.cc",
167 "master_preferences_constants.h", 166 "master_preferences_constants.h",
168 ] 167 ]
169 } 168 }
170 } 169 }
171 170
172 action("generate_strings") { 171 action("strings") {
173 visibility = [ ":strings" ]
174 script = "prebuild/create_string_rc.py" 172 script = "prebuild/create_string_rc.py"
175 173
176 if (is_chrome_branded) { 174 if (is_chrome_branded) {
177 grdfile = "//chrome/app/google_chrome_strings.grd" 175 grdfile = "//chrome/app/google_chrome_strings.grd"
178 } else { 176 } else {
179 grdfile = "//chrome/app/chromium_strings.grd" 177 grdfile = "//chrome/app/chromium_strings.grd"
180 } 178 }
181 179
182 inputs = [ 180 inputs = [
183 grdfile, 181 grdfile,
184 ] 182 ]
185 183
184 # TODO(brettw) move to target_gen_dir
185 outdir = "$root_gen_dir/installer_util_strings"
186 outputs = [ 186 outputs = [
187 "$target_gen_dir/installer_util_strings.h", 187 "$outdir/installer_util_strings.h",
188 "$target_gen_dir/installer_util_strings.rc", 188 "$outdir/installer_util_strings.rc",
189 ] 189 ]
190 190
191 args = [ 191 args = [
192 "-i", 192 "-i",
193 rebase_path(grdfile, root_build_dir) + ":resources", 193 rebase_path(grdfile, root_build_dir) + ":resources",
194 "-n", 194 "-n",
195 "installer_util_strings", 195 "installer_util_strings",
196 "-o", 196 "-o",
197 rebase_path(target_gen_dir, root_build_dir), 197 rebase_path(outdir, root_build_dir),
198 ] 198 ]
199 } 199 }
200
201 # Compile the generated .rc file.
202 source_set("strings") {
203 sources = get_target_outputs(":generate_strings")
204 deps = [
205 ":generate_strings",
206 ]
207 }
208
209 if (is_win) {
210 test("installer_util_unittests") {
211 sources = [
212 "../setup/compat_checks_unittest.cc",
213 "../setup/setup_constants.cc",
214 "advanced_firewall_manager_win_unittest.cc",
215 "callback_work_item_unittest.cc",
216 "channel_info_unittest.cc",
217 "copy_tree_work_item_unittest.cc",
218 "create_dir_work_item_unittest.cc",
219 "create_reg_key_work_item_unittest.cc",
220 "delete_after_reboot_helper_unittest.cc",
221 "delete_reg_key_work_item_unittest.cc",
222 "delete_reg_value_work_item_unittest.cc",
223 "delete_tree_work_item_unittest.cc",
224 "duplicate_tree_detector_unittest.cc",
225 "fake_installation_state.h",
226 "fake_product_state.h",
227 "google_update_settings_unittest.cc",
228 "install_util_unittest.cc",
229 "installation_validation_helper.cc",
230 "installation_validation_helper.h",
231 "installation_validator_unittest.cc",
232 "installer_state_unittest.cc",
233 "installer_util_test_common.cc",
234 "installer_util_test_common.h",
235 "installer_util_unittests.rc",
236 "installer_util_unittests_resource.h",
237 "language_selector_unittest.cc",
238 "legacy_firewall_manager_win_unittest.cc",
239 "logging_installer_unittest.cc",
240 "lzma_util_unittest.cc",
241 "master_preferences_unittest.cc",
242 "move_tree_work_item_unittest.cc",
243 "product_state_unittest.cc",
244 "product_unittest.cc",
245 "product_unittest.h",
246 "registry_key_backup_unittest.cc",
247 "registry_test_data.cc",
248 "registry_test_data.h",
249 "run_all_unittests.cc",
250 "self_cleaning_temp_dir_unittest.cc",
251 "set_reg_value_work_item_unittest.cc",
252 "shell_util_unittest.cc",
253 "uninstall_metrics_unittest.cc",
254 "wmi_unittest.cc",
255 "work_item_list_unittest.cc",
256 ]
257
258 deps = [
259 ":strings",
260 ":util",
261 "//base",
262 "//base:i18n",
263 "//base/test:test_support",
264 "//chrome:chrome_version_resources",
265 "//chrome/installer/test:alternate_version_generator_lib",
266 "//content/public/common",
267 "//testing/gmock",
268 "//testing/gtest",
269 ]
270
271 # TODO(GYP) manifest: $(ProjectDir)\\installer\\mini_installer\\mini_install er.exe.manifest
272 }
273 } # is_win
OLDNEW
« no previous file with comments | « chrome/installer/upgrade_test.gyp ('k') | chrome/installer/util/browser_distribution.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698