Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1116263002: Revert of Add installer_util_unittests to the GN windows build (Closed)

Created:
5 years, 7 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@wintests3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add installer_util_unittests to the GN windows build (patchset #5 id:80001 of https://codereview.chromium.org/1062743006/) Reason for revert: Compilation errors that look related to the installer_util_strings.rc move: http://build.chromium.org/p/chromium/builders/Win/builds/31460 Original issue's description: > Add installer_util_unittests to the GN windows build > > This fixes some C++ Warnings on Windows to avoid having to add suppressions to the GN build. > > Moves the generated strings header to the same place in the gen tree as it is in the source tree. Update includes. > > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg > > Committed: https://crrev.com/cb55755a09b9e2d8c5b05b7a4ad2ff8631e15b13 > Cr-Commit-Position: refs/heads/master@{#327790} TBR=dpranke@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/b356c585d9f6841dcc7df05b8e7cfad0a2b4bdf6 Cr-Commit-Position: refs/heads/master@{#327799}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -194 lines) Patch
M BUILD.gn View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/app_installer/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_installer.gypi View 5 chunks +5 lines, -8 lines 0 comments Download
M chrome/installer/setup/app_launcher_installer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/setup/setup_main.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/installer/setup/setup_unittests.rc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/installer/test/BUILD.gn View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/installer/test/alternate_version_generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/installer/test/resource_updater.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/installer/upgrade_test.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
M chrome/installer/util/BUILD.gn View 5 chunks +7 lines, -81 lines 0 comments Download
M chrome/installer/util/browser_distribution.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/chrome_frame_distribution.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/delete_after_reboot_helper_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/installer/util/firewall_manager_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/google_chrome_distribution.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/google_chrome_sxs_distribution.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/installer_state_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/installer_util_unittests.rc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/language_selector.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/installer/util/logging_installer_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/installer/util/master_preferences_unittest.cc View 4 chunks +4 lines, -8 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
rickyz (no longer on Chrome)
Created Revert of Add installer_util_unittests to the GN windows build
5 years, 7 months ago (2015-04-30 21:46:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116263002/1
5 years, 7 months ago (2015-04-30 21:47:04 UTC) #2
Dirk Pranke
lgtm
5 years, 7 months ago (2015-04-30 21:50:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 21:55:14 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 21:56:58 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b356c585d9f6841dcc7df05b8e7cfad0a2b4bdf6
Cr-Commit-Position: refs/heads/master@{#327799}

Powered by Google App Engine
This is Rietveld 408576698