Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: Source/modules/mediastream/RTCPeerConnection.cpp

Issue 1116253004: Add RtcpMuxPolicy to PeerConnection. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/RTCPeerConnection.cpp
diff --git a/Source/modules/mediastream/RTCPeerConnection.cpp b/Source/modules/mediastream/RTCPeerConnection.cpp
index 51a5d99241a3b761e296aeab803183121f94da90..e313c85c4d73f5dc4b5bc60823001e7debc34010 100644
--- a/Source/modules/mediastream/RTCPeerConnection.cpp
+++ b/Source/modules/mediastream/RTCPeerConnection.cpp
@@ -129,9 +129,21 @@ RTCConfiguration* RTCPeerConnection::parseConfiguration(const Dictionary& config
}
}
+ RTCRtcpMuxPolicy rtcpMuxPolicy = RTCRtcpMuxPolicyRequire;
tommi (sloooow) - chröme 2015/05/22 15:46:10 Shouldn't this be initialized to WebRTCRtcpMuxPoli
pthatcher2 2015/05/22 15:55:27 Yes, thank you for noticing that. That could have
+ String rtcpMuxPolicyString;
+ if (DictionaryHelper::get(configuration, "rtcpMuxPolicy", rtcpMuxPolicyString)) {
+ if (rtcpMuxPolicyString == "require") {
+ rtcpMuxPolicy = RTCRtcpMuxPolicyRequire;
+ } else if (rtcpMuxPolicyString != "negotiate") {
+ exceptionState.throwTypeError("Malformed RTCRtcpMuxPolicy");
+ return 0;
+ }
+ }
+
RTCConfiguration* rtcConfiguration = RTCConfiguration::create();
rtcConfiguration->setIceTransports(iceTransports);
rtcConfiguration->setBundlePolicy(bundlePolicy);
+ rtcConfiguration->setRtcpMuxPolicy(rtcpMuxPolicy);
for (size_t i = 0; i < numberOfServers; ++i) {
Dictionary iceServer;
« no previous file with comments | « LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt ('k') | Source/platform/exported/WebRTCConfiguration.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698