Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(52)

Issue 1116253004: Add RtcpMuxPolicy to PeerConnection. (Closed)

Created:
5 years ago by pthatcher2
Modified:
4 years, 10 months ago
CC:
blink-reviews, dglazkov+blink, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : make negotiate the default #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -1 line) Patch
M LayoutTests/fast/mediastream/RTCPeerConnection.html View 1 chunk +4 lines, -0 lines 0 comments Download
M LayoutTests/fast/mediastream/RTCPeerConnection-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 1 2 1 chunk +12 lines, -0 lines 0 comments Download
M Source/platform/exported/WebRTCConfiguration.cpp View 1 1 chunk +14 lines, -0 lines 0 comments Download
M Source/platform/mediastream/RTCConfiguration.h View 1 2 chunks +12 lines, -1 line 0 comments Download
M public/platform/WebRTCConfiguration.h View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (7 generated)
pthatcher2
5 years ago (2015-04-30 22:40:38 UTC) #2
pfeldman
You want rtc reviews in the list.
4 years, 11 months ago (2015-05-16 00:06:25 UTC) #3
pthatcher2
4 years, 11 months ago (2015-05-20 19:54:39 UTC) #6
juberti2
lgtm, fwiw
4 years, 11 months ago (2015-05-20 22:29:49 UTC) #7
pthatcher2
On 2015/05/20 22:29:49, juberti2 wrote: > lgtm, fwiw pfeldman? Can you take a look now?
4 years, 11 months ago (2015-05-22 04:17:09 UTC) #8
pthatcher2
On 2015/05/22 04:17:09, pthatcher2 wrote: > On 2015/05/20 22:29:49, juberti2 wrote: > > lgtm, fwiw ...
4 years, 11 months ago (2015-05-22 04:17:29 UTC) #9
pthatcher2
4 years, 11 months ago (2015-05-22 15:36:06 UTC) #11
tommi (sloooow) - chröme
https://codereview.chromium.org/1116253004/diff/20001/Source/modules/mediastream/RTCPeerConnection.cpp File Source/modules/mediastream/RTCPeerConnection.cpp (right): https://codereview.chromium.org/1116253004/diff/20001/Source/modules/mediastream/RTCPeerConnection.cpp#newcode132 Source/modules/mediastream/RTCPeerConnection.cpp:132: RTCRtcpMuxPolicy rtcpMuxPolicy = RTCRtcpMuxPolicyRequire; Shouldn't this be initialized to ...
4 years, 11 months ago (2015-05-22 15:46:11 UTC) #12
pthatcher2
https://codereview.chromium.org/1116253004/diff/20001/Source/modules/mediastream/RTCPeerConnection.cpp File Source/modules/mediastream/RTCPeerConnection.cpp (right): https://codereview.chromium.org/1116253004/diff/20001/Source/modules/mediastream/RTCPeerConnection.cpp#newcode132 Source/modules/mediastream/RTCPeerConnection.cpp:132: RTCRtcpMuxPolicy rtcpMuxPolicy = RTCRtcpMuxPolicyRequire; On 2015/05/22 15:46:10, tommi wrote: ...
4 years, 11 months ago (2015-05-22 15:55:27 UTC) #13
tommi (sloooow) - chröme
lgtm
4 years, 11 months ago (2015-05-22 17:18:17 UTC) #14
pthatcher2
Mike West, I saw you reviewed a similar WebRTC CL (https://codereview.chromium.org/1171553002/). I've been waiting for ...
4 years, 10 months ago (2015-06-08 22:34:40 UTC) #16
Mike West
On 2015/06/08 at 22:34:40, pthatcher wrote: > Mike West, > > I saw you reviewed ...
4 years, 10 months ago (2015-06-12 07:35:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116253004/40001
4 years, 10 months ago (2015-06-18 17:09:58 UTC) #20
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 18:34:34 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197386

Powered by Google App Engine
This is Rietveld 408576698