Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1116233004: Revert of [V8] Use previous token location as EOS token location (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
Reviewers:
kozy, Yang, yurys
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [V8] Use previous token location as EOS token location (patchset #2 id:20001 of https://codereview.chromium.org/1100993003/) Reason for revert: [Sheriff] Speculative revert. This seems to block the current roll: https://codereview.chromium.org/1124463003/ This bisect also points at this CL: https://codereview.chromium.org/1124523002/ Please prepare the chromium side tests before a reland. Original issue's description: > [V8] Use previous token location as EOS token location > > EOS token location is useless for users and messages.js are not ready for its location. > With this CL we use location of token before EOS for it. > > LOG=Y > BUG=chromium:480652 > R=yurys@chromium.org,yangguo@chromium.org > > Committed: https://crrev.com/81afc9313ce84350bcba9f84b255a77e97cd3726 > Cr-Commit-Position: refs/heads/master@{#28164} TBR=yangguo@chromium.org,yurys@chromium.org,kozyatinskiy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:480652 Committed: https://crrev.com/8e3d776dcb5dfa75b1bc24b199465fb814bb4a0c Cr-Commit-Position: refs/heads/master@{#28187}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M src/scanner.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [V8] Use previous token location as EOS token location
5 years, 7 months ago (2015-05-03 12:47:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116233004/1
5 years, 7 months ago (2015-05-03 12:47:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-03 12:47:52 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-03 12:48:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e3d776dcb5dfa75b1bc24b199465fb814bb4a0c
Cr-Commit-Position: refs/heads/master@{#28187}

Powered by Google App Engine
This is Rietveld 408576698