Issue 111613005: Start removing support for in-process NPAPI plugins. This was a debugging mode and was only support…

Issue 111613005: Start removing support for in-process NPAPI plugins. This was a debugging mode and was only support… (Closed)

Created:
6 years, 12 months ago by jam

Modified:
6 years, 12 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, miu+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Start removing support for in-process NPAPI plugins. This was a debugging mode and was only supported by non-Aura Windows code. BUG=330735 R=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242552

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comments #

Created: 6 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -105 lines)			Patch
M	content/browser/renderer_host/render_process_host_impl.cc	View		2 chunks	+0 lines, -14 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_base.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	content/public/common/content_switches.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/npapi/webplugin_impl.h	View		4 chunks	+2 lines, -5 lines	0 comments	Download
M	content/renderer/npapi/webplugin_impl.cc	View		3 chunks	+4 lines, -20 lines	0 comments	Download
M	content/renderer/render_process.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/render_process_impl.h	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	content/renderer/render_process_impl.cc	View		3 chunks	+0 lines, -19 lines	0 comments	Download
M	content/renderer/render_thread_impl.h	View		2 chunks	+0 lines, -11 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View		2 chunks	+0 lines, -8 lines	0 comments	Download
M	content/renderer/renderer_main.cc	View	1	1 chunk	+2 lines, -5 lines	0 comments	Download
M	content/test/mock_render_process.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/test/mock_render_process.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/test/webrtc_audio_device_test.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

So much red, what's not to like? LGTM with the change noted. https://codereview.chromium.org/111613005/diff/1/content/renderer/renderer_main.cc File content/renderer/renderer_main.cc ...

6 years, 12 months ago (2013-12-26 20:32:16 UTC) #3

jam

https://codereview.chromium.org/111613005/diff/1/content/renderer/renderer_main.cc File content/renderer/renderer_main.cc (right): https://codereview.chromium.org/111613005/diff/1/content/renderer/renderer_main.cc#newcode166 content/renderer/renderer_main.cc:166: base::MessageLoop main_message_loop(base::MessageLoop::TYPE_DEFAULT); On 2013/12/26 20:32:16, Avi wrote: > The ...

6 years, 12 months ago (2013-12-26 20:52:31 UTC) #5

Message was sent while issue was closed.

SLGTM.

Expand Messages | Collapse Messages