Improve caching of dashed paths in GrStencilAndCoverPathRenderer

src/gpu/GrStrokeInfo.h

 /*
  * Copyright 2014 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef GrStrokeInfo_DEFINED
 #define GrStrokeInfo_DEFINED
 
@@ skipping 37 matching lines @@
             fDashPhase = other.fDashPhase;
             fIntervals.reset(other.getDashCount());
             memcpy(fIntervals.get(), other.fIntervals.get(), fIntervals.count() * sizeof(SkScalar));
         } else {
             this->removeDash();
         }
         fStroke = other.fStroke;
         return *this;
     }
 
+    bool operator==(const GrStrokeInfo& other) const {
+        if (this->isDashed() != other.isDashed()) {
+            return false;
+        }
+        if (this->isDashed()) {
+            if (fDashPhase != other.fDashPhase ||
+                    fIntervals.count() != other.fIntervals.count() ||

[egdaniel, 2015/05/05 19:48:44]

align these lines under each other? It could be that there is a tab char that my
viewer is showing as 8 chars. If that is the case just turn into spaces.

[Kimmo Kinnunen, 2015/05/06 08:30:25]

It was intentional -- some reviewers want *me* to hilight the "if" body contents
by indenting the multiline condition irregularly by extra 4 spaces.

Done.

+                    memcmp(fIntervals.get(), other.fIntervals.get(),
+                           fIntervals.count() * sizeof(SkScalar)) != 0) {
+                return false;
+            }
+        }
+        return fStroke == other.fStroke;
+    }
+
     const SkStrokeRec& getStrokeRec() const { return fStroke; }
 
     SkStrokeRec* getStrokeRecPtr() { return &fStroke; }
 
     void setFillStyle() { fStroke.setFillStyle(); }
 
     /*
      * This functions takes in a patheffect and updates the dashing information if the path effect
      * is a Dash type. Returns true if the path effect is a dashed effect and we are stroking,
      * otherwise it returns false.
@@ skipping 70 matching lines @@
         this->setDashInfo(pe);
     }
 
     SkStrokeRec            fStroke;
     SkPathEffect::DashType fDashType;
     SkScalar               fDashPhase;
     SkAutoSTArray<2, SkScalar> fIntervals;
 };
 
 #endif