MIPS: Do not use the 64-bit floor and truncate instructions in fp32 mode.

MIPS: Do not use the 64-bit floor and truncate instructions in fp32 mode.

These instructions have unpredictable result when the processor is in fp32 mode.

BUG=

TEST=mjsunit/math-floor-global,math-floor-local,math-floor-part1

Committed: https://crrev.com/900bc7937c28219b39fcc5776ce945cf6fda367e
Cr-Commit-Position: refs/heads/master@{#28194}

[dusmil.imgtec, 2015-04-30 14:35:37]

dusan.milosavljevic@imgtec.com changed reviewers:
+ dusan.milosavljevic@imgtec.com

[dusmil.imgtec, 2015-04-30 14:35:38]

https://codereview.chromium.org/1116073002/diff/1/src/compiler/mips/instructi...
File src/compiler/mips/instruction-selector-mips.cc (right):

https://codereview.chromium.org/1116073002/diff/1/src/compiler/mips/instructi...
src/compiler/mips/instruction-selector-mips.cc:984: kFpuMode == kFP64) {
You should use IsFp64Mode() instead.

[akos.palfi.imgtec, 2015-04-30 14:45:49]

Thanks, Dusan. I've uploaded a new patchset.

https://codereview.chromium.org/1116073002/diff/1/src/compiler/mips/instructi...
File src/compiler/mips/instruction-selector-mips.cc (right):

https://codereview.chromium.org/1116073002/diff/1/src/compiler/mips/instructi...
src/compiler/mips/instruction-selector-mips.cc:984: kFpuMode == kFP64) {
On 2015/04/30 14:35:38, dusmil.imgtec wrote:
> You should use IsFp64Mode() instead.

Done.

[paul.l..., 2015-05-04 05:08:58]

paul.lind@imgtec.com changed reviewers:
+ paul.lind@imgtec.com

[paul.l..., 2015-05-04 05:08:59]

nit: let's change the subject/commit message to say 'fp32' mode, so that we are
consistent with the code that uses IsFp64Mode(). We can try to avoid the
alternate 'FR=0/1' and '16-registers' terminology for the same thing.

[akos.palfi.imgtec, 2015-05-04 09:38:09]

On 2015/05/04 05:08:59, paul.l... wrote:
> nit: let's change the subject/commit message to say 'fp32' mode, so that we
are
> consistent with the code that uses IsFp64Mode(). We can try to avoid the
> alternate 'FR=0/1' and '16-registers' terminology for the same thing.

Thanks, done.

[dusmil.imgtec, 2015-05-04 10:27:41]

LGTM.

[akos.palfi.imgtec, 2015-05-04 11:12:47]

akos.palfi@imgtec.com changed reviewers:
+ danno@chromium.org

[akos.palfi.imgtec, 2015-05-04 11:13:07]

The CQ bit was checked by akos.palfi@imgtec.com

[commit-bot: I haz the power, 2015-05-04 11:13:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1116073002/20001

[commit-bot: I haz the power, 2015-05-04 12:06:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-04 12:06:20]

Patchset 2 (id:??) landed as
https://crrev.com/900bc7937c28219b39fcc5776ce945cf6fda367e
Cr-Commit-Position: refs/heads/master@{#28194}