Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Unified Diff: Source/modules/filesystem/SyncCallbackHelper.h

Issue 111603006: Simplify invokeCallback() and support void return values for IDL callbacks (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/filesystem/SyncCallbackHelper.h
diff --git a/Source/modules/filesystem/SyncCallbackHelper.h b/Source/modules/filesystem/SyncCallbackHelper.h
index ced54ec13b36ac96d5271f7ca072854389e4e579..ad39e1c636c7705971dd67bd2a153d32a9866fb4 100644
--- a/Source/modules/filesystem/SyncCallbackHelper.h
+++ b/Source/modules/filesystem/SyncCallbackHelper.h
@@ -111,16 +111,14 @@ private:
return adoptPtr(new SuccessCallbackImpl(helper));
}
- virtual bool handleEvent()
+ virtual void handleEvent()
{
m_helper->setError(FileError::OK);
- return true;
}
- virtual bool handleEvent(CallbackArg arg)
+ virtual void handleEvent(CallbackArg arg)
{
m_helper->setResult(arg);
- return true;
}
private:
@@ -138,11 +136,10 @@ private:
return adoptPtr(new ErrorCallbackImpl(helper));
}
- virtual bool handleEvent(FileError* error)
+ virtual void handleEvent(FileError* error)
{
ASSERT(error);
m_helper->setError(error->code());
- return true;
}
private:

Powered by Google App Engine
This is Rietveld 408576698