Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: Source/bindings/v8/custom/V8SQLTransactionCustom.cpp

Issue 111603006: Simplify invokeCallback() and support void return values for IDL callbacks (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8SQLTransactionCustom.cpp
diff --git a/Source/bindings/v8/custom/V8SQLTransactionCustom.cpp b/Source/bindings/v8/custom/V8SQLTransactionCustom.cpp
index be2c45f7fb784e977a5c8740f33265f7aa194913..9a314b5f6669fedcce9c2435a8dbd223f297410f 100644
--- a/Source/bindings/v8/custom/V8SQLTransactionCustom.cpp
+++ b/Source/bindings/v8/custom/V8SQLTransactionCustom.cpp
@@ -96,7 +96,7 @@ void V8SQLTransaction::executeSqlMethodCustom(const v8::FunctionCallbackInfo<v8:
setDOMException(TypeMismatchError, info.GetIsolate());
return;
}
- callback = V8SQLStatementCallback::create(v8::Handle<v8::Object>::Cast(info[2]), executionContext);
+ callback = V8SQLStatementCallback::create(v8::Handle<v8::Function>::Cast(info[2]), executionContext);
}
OwnPtr<SQLStatementErrorCallback> errorCallback;
@@ -105,7 +105,7 @@ void V8SQLTransaction::executeSqlMethodCustom(const v8::FunctionCallbackInfo<v8:
setDOMException(TypeMismatchError, info.GetIsolate());
return;
}
- errorCallback = V8SQLStatementErrorCallback::create(v8::Handle<v8::Object>::Cast(info[3]), executionContext);
+ errorCallback = V8SQLStatementErrorCallback::create(v8::Handle<v8::Function>::Cast(info[3]), executionContext);
}
ExceptionState exceptionState(info.Holder(), info.GetIsolate());

Powered by Google App Engine
This is Rietveld 408576698