Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: Source/bindings/tests/results/V8TestCallback.h

Issue 111603006: Simplify invokeCallback() and support void return values for IDL callbacks (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestCallback.h
diff --git a/Source/bindings/tests/results/V8TestCallback.h b/Source/bindings/tests/results/V8TestCallback.h
index 6b1a24bd72265f27851fe4c6a5940bd890a1f37a..44d735d815cdfa48d159d2175cf4a3ad85e7d7f8 100644
--- a/Source/bindings/tests/results/V8TestCallback.h
+++ b/Source/bindings/tests/results/V8TestCallback.h
@@ -44,7 +44,7 @@ class ExecutionContext;
class V8TestCallback : public TestCallback, public ActiveDOMCallback {
public:
- static PassOwnPtr<V8TestCallback> create(v8::Handle<v8::Object> callback, ExecutionContext* context)
+ static PassOwnPtr<V8TestCallback> create(v8::Handle<v8::Function> callback, ExecutionContext* context)
{
ASSERT(context);
return adoptPtr(new V8TestCallback(callback, context));
@@ -60,10 +60,11 @@ public:
virtual bool callbackWithSequenceArg(const Vector<RefPtr<TestInterfaceEmpty> >& sequenceArg);
virtual bool callbackWithFloatArg(float floatArg);
virtual bool callbackWithThisArg(ScriptValue thisValue, int arg);
+ virtual void callbackWithVoidReturnValue();
private:
- V8TestCallback(v8::Handle<v8::Object>, ExecutionContext*);
+ V8TestCallback(v8::Handle<v8::Function>, ExecutionContext*);
- ScopedPersistent<v8::Object> m_callback;
+ ScopedPersistent<v8::Function> m_callback;
RefPtr<DOMWrapperWorld> m_world;
};

Powered by Google App Engine
This is Rietveld 408576698