Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Side by Side Diff: Source/core/inspector/InspectorDatabaseAgent.cpp

Issue 111603006: Simplify invokeCallback() and support void return values for IDL callbacks (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 177
178 class TransactionSuccessCallback : public VoidCallback { 178 class TransactionSuccessCallback : public VoidCallback {
179 public: 179 public:
180 static PassOwnPtr<TransactionSuccessCallback> create() 180 static PassOwnPtr<TransactionSuccessCallback> create()
181 { 181 {
182 return adoptPtr(new TransactionSuccessCallback()); 182 return adoptPtr(new TransactionSuccessCallback());
183 } 183 }
184 184
185 virtual ~TransactionSuccessCallback() { } 185 virtual ~TransactionSuccessCallback() { }
186 186
187 virtual bool handleEvent() { return false; } 187 virtual void handleEvent() { }
188 188
189 private: 189 private:
190 TransactionSuccessCallback() { } 190 TransactionSuccessCallback() { }
191 }; 191 };
192 192
193 } // namespace 193 } // namespace
194 194
195 void InspectorDatabaseAgent::didOpenDatabase(PassRefPtr<Database> database, cons t String& domain, const String& name, const String& version) 195 void InspectorDatabaseAgent::didOpenDatabase(PassRefPtr<Database> database, cons t String& domain, const String& name, const String& version)
196 { 196 {
197 if (InspectorDatabaseResource* resource = findByFileName(database->fileName( ))) { 197 if (InspectorDatabaseResource* resource = findByFileName(database->fileName( ))) {
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 322
323 Database* InspectorDatabaseAgent::databaseForId(const String& databaseId) 323 Database* InspectorDatabaseAgent::databaseForId(const String& databaseId)
324 { 324 {
325 DatabaseResourcesMap::iterator it = m_resources.find(databaseId); 325 DatabaseResourcesMap::iterator it = m_resources.find(databaseId);
326 if (it == m_resources.end()) 326 if (it == m_resources.end())
327 return 0; 327 return 0;
328 return it->value->database(); 328 return it->value->database();
329 } 329 }
330 330
331 } // namespace WebCore 331 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698