Simplify invokeCallback() and support void return values for IDL callbacks

Source/bindings/v8/V8Callback.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 18 matching lines @@
  */
 
 #include "config.h"
 #include "bindings/v8/V8Callback.h"
 
 #include "bindings/v8/ScriptController.h"
 #include "core/dom/Document.h"
 
 namespace WebCore {
 
-bool invokeCallback(v8::Handle<v8::Object> callback, int argc, v8::Handle<v8::Value> argv[], bool& callbackReturnValue, ExecutionContext* executionContext, v8::Isolate* isolate)
+bool invokeCallback(v8::Local<v8::Function> callback, int argc, v8::Handle<v8::Value> argv[], ExecutionContext* executionContext, v8::Isolate* isolate)
 {
-    return invokeCallback(callback, isolate->GetCurrentContext()->Global(), argc, argv, callbackReturnValue, executionContext, isolate);
+    return invokeCallback(callback, isolate->GetCurrentContext()->Global(), argc, argv, executionContext, isolate);
 }
 
-bool invokeCallback(v8::Handle<v8::Object> callback, v8::Handle<v8::Object> thisObject, int argc, v8::Handle<v8::Value> argv[], bool& callbackReturnValue, ExecutionContext* executionContext, v8::Isolate* isolate)
+bool invokeCallback(v8::Local<v8::Function> callback, v8::Handle<v8::Object> thisObject, int argc, v8::Handle<v8::Value> argv[], ExecutionContext* executionContext, v8::Isolate* isolate)
 {
     v8::TryCatch exceptionCatcher;
     exceptionCatcher.SetVerbose(true);
-
-    v8::Local<v8::Function> callbackFunction;
-    if (callback->IsFunction()) {
-        callbackFunction = v8::Local<v8::Function>::New(isolate, v8::Handle<v8::Function>::Cast(callback));
-    } else if (callback->IsObject()) {
-        v8::Local<v8::Value> handleEventFunction = callback->Get(v8AtomicString(isolate, "handleEvent"));
-        if (handleEventFunction->IsFunction())
-            callbackFunction = v8::Local<v8::Function>::Cast(handleEventFunction);
-    } else
-        return false;
-
-    if (callbackFunction.IsEmpty())
-        return false;
-
-    v8::Handle<v8::Value> result = ScriptController::callFunction(executionContext, callbackFunction, thisObject, argc, argv, isolate);
-
-    callbackReturnValue = !result.IsEmpty() && result->BooleanValue();
-    return exceptionCatcher.HasCaught();
+    ScriptController::callFunction(executionContext, callback, thisObject, argc, argv, isolate);
+    return !exceptionCatcher.HasCaught();
 }
 
 } // namespace WebCore