Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1116003005: Remove GetDefaultReceiver, pass in undefined to sloppy-mode functions instead. (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 7 months ago
Reviewers:
Igor Sheludko, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove GetDefaultReceiver, pass in undefined to sloppy-mode functions instead. Committed: https://crrev.com/5f9c0df4368abfa638893a1415399ef6ce1dd37b Cr-Commit-Position: refs/heads/master@{#28255}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Make sure it does TO_OBJECT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -82 lines) Patch
M src/array.js View 1 13 chunks +24 lines, -28 lines 0 comments Download
M src/collection.js View 2 chunks +6 lines, -6 lines 0 comments Download
M src/harmony-array.js View 1 3 chunks +12 lines, -10 lines 0 comments Download
M src/harmony-typedarray.js View 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/string.js View 1 6 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Toon Verwaest
PTAL
5 years, 7 months ago (2015-05-04 09:32:24 UTC) #2
rossberg
https://codereview.chromium.org/1116003005/diff/1/src/array.js File src/array.js (right): https://codereview.chromium.org/1116003005/diff/1/src/array.js#newcode1157 src/array.js:1157: if (%IsSloppyModeFunction(f)) receiver = UNDEFINED; Can we have a ...
5 years, 7 months ago (2015-05-04 11:00:17 UTC) #3
Toon Verwaest
Fixed the ToObject by just using TO_OBJECT_INLINE which does IsSpecObject internally. I'll leave replacing the ...
5 years, 7 months ago (2015-05-04 12:23:57 UTC) #4
rossberg
lgtm
5 years, 7 months ago (2015-05-06 09:46:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1116003005/20001
5 years, 7 months ago (2015-05-06 11:34:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-06 11:58:34 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 11:58:49 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f9c0df4368abfa638893a1415399ef6ce1dd37b
Cr-Commit-Position: refs/heads/master@{#28255}

Powered by Google App Engine
This is Rietveld 408576698