Test CL for WebKit try bot.

third_party/WebKit/WebCore/loader/FrameLoader.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008 Alp Toker <alp@atoker.com>
  * Copyright (C) Research In Motion Limited 2009. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
@@ skipping 185 matching lines @@
     , m_shouldCallCheckCompleted(false)
     , m_shouldCallCheckLoadComplete(false)
     , m_opener(0)
     , m_creatingInitialEmptyDocument(false)
     , m_isDisplayingInitialEmptyDocument(false)
     , m_committedFirstRealDocumentLoad(false)
     , m_didPerformFirstNavigation(false)
     , m_loadingFromCachedPage(false)
     , m_suppressOpenerInNewFrame(false)
     , m_sandboxFlags(SandboxAll)
+    , m_userGestureSet(false)
+    , m_userGesture(false)
 #ifndef NDEBUG
     , m_didDispatchDidCommitLoad(false)
 #endif
 {
 }
 
 FrameLoader::~FrameLoader()
 {
     setOpener(0);
 
@@ skipping 247 matching lines @@
         return;
 
     if (protocolIsJavaScript(u)) {
         m_isExecutingJavaScriptFormAction = true;
         m_frame->script()->executeIfJavaScriptURL(u, false, false);
         m_isExecutingJavaScriptFormAction = false;
         return;
     }
 
     FrameLoadRequest frameRequest;
+    frameRequest.setIsFromUserGesture(isProcessingUserGesture());
 
     String targetOrBaseTarget = target.isEmpty() ? m_frame->document()->baseTarget() : target;
     Frame* targetFrame = m_frame->tree()->find(targetOrBaseTarget);
     if (!shouldAllowNavigation(targetFrame))
         return;
     if (!targetFrame) {
+        if (!DOMWindow::allowPopUp(m_frame) && !isProcessingUserGesture())
+            return;
+
         targetFrame = m_frame;
         frameRequest.setFrameName(targetOrBaseTarget);
     }
     if (!targetFrame->page())
         return;
 
     // FIXME: We'd like to remove this altogether and fix the multiple form submission issue another way.
 
     // We do not want to submit more than one form from the same page, nor do we want to submit a single
     // form more than once. This flag prevents these from happening; not sure how other browsers prevent this.
@@ skipping 1025 matching lines @@
     m_firstLayoutDone = false;
     m_frame->redirectScheduler()->cancel(true);
     m_client->provisionalLoadStarted();
 }
 
 bool FrameLoader::isProcessingUserGesture()
 {
     Frame* frame = m_frame->tree()->top();
     if (!frame->script()->canExecuteScripts(NotAboutToExecuteScript))
         return true; // If JavaScript is disabled, a user gesture must have initiated the navigation.
+    // Check to see if we're using an override because the frame load was
+    // initiated by a non-current script context.
+    if (m_userGestureSet)
+        return m_userGesture;
     return frame->script()->processingUserGesture(mainThreadNormalWorld()); // FIXME: Use pageIsProcessingUserGesture.
 }
 
 void FrameLoader::resetMultipleFormSubmissionProtection()
 {
     m_submittedFormURL = KURL();
 }
 
 void FrameLoader::setEncoding(const String& name, bool userChosen)
 {
@@ skipping 408 matching lines @@
         referrer = String();
     
     FrameLoadType loadType;
     if (request.resourceRequest().cachePolicy() == ReloadIgnoringCacheData)
         loadType = FrameLoadTypeReload;
     else if (lockBackForwardList)
         loadType = FrameLoadTypeRedirectWithLockedBackForwardList;
     else
         loadType = FrameLoadTypeStandard;
 
+    // For things like form POSTs, the resulting frame load here is occurring
+    // asynchronously. If necessary, consider the user gesture status from the
+    // original context.
+    if (request.isFromUserGestureSet()) {
+        m_userGestureSet = true;
+        m_userGesture = request.isFromUserGesture();
+    }
     if (request.resourceRequest().httpMethod() == "POST")
         loadPostRequest(request.resourceRequest(), referrer, request.frameName(), lockHistory, loadType, event, formState.get());
     else
         loadURL(request.resourceRequest().url(), referrer, request.frameName(), lockHistory, loadType, event, formState.get());
+    m_userGestureSet = false;
+    m_userGesture = false;
 
     // FIXME: It's possible this targetFrame will not be the same frame that was targeted by the actual
     // load if frame names have changed.
     Frame* sourceFrame = formState ? formState->sourceFrame() : m_frame;
     Frame* targetFrame = sourceFrame->loader()->findFrameForNavigation(request.frameName());
     if (targetFrame && targetFrame != sourceFrame) {
         if (Page* page = targetFrame->page())
             page->chrome()->focus();
     }
 }
@@ skipping 2154 matching lines @@
         m_client->dispatchDidLoadResourceFromMemoryCache(m_documentLoader.get(), request, resource->response(), resource->encodedSize());
     }
 }
 
 bool FrameLoaderClient::hasHTMLView() const
 {
     return true;
 }
 
 } // namespace WebCore