Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Unified Diff: pkg/analyzer/lib/src/generated/constant.dart

Issue 1115993005: Clone AST nodes of default formal parameters prior to constant evaluation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/constant.dart
diff --git a/pkg/analyzer/lib/src/generated/constant.dart b/pkg/analyzer/lib/src/generated/constant.dart
index 1c274562a94502cb98a0d4b78a2bb330802a34f6..effe860933982c5f07ee1a8b79d48ec8cd3bca94 100644
--- a/pkg/analyzer/lib/src/generated/constant.dart
+++ b/pkg/analyzer/lib/src/generated/constant.dart
@@ -1148,9 +1148,9 @@ class ConstantValueComputer {
constructor.isCycleFree = true;
} else if (constNode is FormalParameter) {
if (constNode is DefaultFormalParameter) {
- DefaultFormalParameter parameter = constNode;
- ParameterElement element = parameter.element;
- Expression defaultValue = parameter.defaultValue;
+ ParameterElement element = constNode.element;
+ Expression defaultValue =
+ (element as PotentiallyConstVariableElement).constantInitializer;
if (defaultValue != null) {
RecordingErrorListener errorListener = new RecordingErrorListener();
ErrorReporter errorReporter =
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/element.dart » ('j') | pkg/analyzer/lib/src/generated/element.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698