Issue 1115993004: base: Remove gcc and msvs workaround limitations for arraysize template magic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1115993004: base: Remove gcc and msvs workaround limitations for arraysize template magic. (Closed)

Created:
5 years, 7 months ago by tfarina

Modified:
5 years, 7 months ago

Reviewers:
danakj, brucedawson

CC:
chromium-reviews, erikwright+watch_chromium.org, grt (UTC plus 2)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

base: Remove gcc and msvs workaround limitations for arraysize template magic. Mike (mtklein) built this simplified version when doing https://codereview.chromium.org/1114283003/. TEST=trybots seems happy R=danakj@chromium.org Committed: https://crrev.com/2e252345d488b3120cdff29d3afc087b36707d8d Cr-Commit-Position: refs/heads/master@{#328904}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -12 lines)			Patch
	M	base/macros.h	View		1 chunk	+2 lines, -12 lines	0 comments	Download

Total messages: 7 (1 generated)

brucedawson

lgtm - if it compiles everywhere then I think it must be correct (but I'm ...

5 years, 7 months ago (2015-05-07 00:47:09 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115993004/20001

5 years, 7 months ago (2015-05-08 00:04:14 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-08 02:16:19 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/2e252345d488b3120cdff29d3afc087b36707d8d
Cr-Commit-Position: refs/heads/master@{#328904}