Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: src/mips/code-stubs-mips.cc

Issue 1115973005: Revert of Collect type feedback on result of Math.[round|ceil|floor] (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/math.js ('k') | src/mips/macro-assembler-mips.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/mips/code-stubs-mips.cc
diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc
index 0e81adf7a751c2c1024dc55367aaa3bdca9b7953..ca0d2e94c08e3b5bdae24be13d9c6a3197715ddb 100644
--- a/src/mips/code-stubs-mips.cc
+++ b/src/mips/code-stubs-mips.cc
@@ -2852,155 +2852,6 @@
}
-void CallIC_RoundStub::Generate(MacroAssembler* masm) {
- Register function = a1;
- Register vector = a2;
- Register slot = a3;
-
- Register temp1 = a0;
- Register temp2 = t0;
- DoubleRegister double_temp1 = f12;
- DoubleRegister double_temp2 = f14;
- Label tail, miss;
-
- // Ensure nobody has snuck in another function.
- __ BranchIfNotBuiltin(function, temp1, kMathRound, &miss);
-
- if (arg_count() > 0) {
- __ lw(temp1, MemOperand(sp, (arg_count() - 1) * kPointerSize));
- Handle<Map> map = isolate()->factory()->heap_number_map();
- __ CheckMap(temp1, temp2, map, &tail, DO_SMI_CHECK);
- __ ldc1(double_temp1, FieldMemOperand(temp1, HeapNumber::kValueOffset));
-
- // If the number is >0, it doesn't round to -0
- __ Move(double_temp2, 0.0);
- __ BranchF64(&tail, nullptr, gt, double_temp1, double_temp2);
-
- // If the number is <-.5, it doesn't round to -0
- __ Move(double_temp2, -.5);
- __ BranchF64(&tail, nullptr, lt, double_temp1, double_temp2);
-
- // +0 doesn't round to -0
- __ FmoveHigh(temp1, double_temp1);
- __ Branch(&tail, ne, temp1, Operand(0x80000000));
-
- __ sll(temp1, slot, 1);
- __ Addu(temp1, temp1, vector);
- __ li(temp2, Operand(Smi::FromInt(kHasReturnedMinusZeroSentinel)));
- __ sw(temp2,
- FieldMemOperand(temp1, FixedArray::kHeaderSize + kPointerSize));
- }
-
- __ bind(&tail);
- // The slow case, we need this no matter what to complete a call after a miss.
- CallFunctionNoFeedback(masm, arg_count(), true, CallAsMethod());
-
- // Unreachable.
- __ stop("Unreachable");
-
- __ bind(&miss);
- GenerateMiss(masm);
- __ Branch(&tail);
-}
-
-
-void CallIC_FloorStub::Generate(MacroAssembler* masm) {
- Register function = a1;
- Register vector = a2;
- Register slot = a3;
-
- Register temp1 = a0;
- Register temp2 = t0;
- DoubleRegister double_temp = f12;
- Label tail, miss;
-
- // Ensure nobody has snuck in another function.
- __ BranchIfNotBuiltin(function, temp1, kMathFloor, &miss);
-
- if (arg_count() > 0) {
- __ lw(temp1, MemOperand(sp, (arg_count() - 1) * kPointerSize));
- Handle<Map> map = isolate()->factory()->heap_number_map();
- __ CheckMap(temp1, temp2, map, &tail, DO_SMI_CHECK);
- __ ldc1(double_temp, FieldMemOperand(temp1, HeapNumber::kValueOffset));
-
- // Only -0 floors to -0.
- __ FmoveHigh(temp1, double_temp);
- __ Branch(&tail, ne, temp1, Operand(0x80000000));
- __ FmoveLow(temp1, double_temp);
- __ Branch(&tail, ne, temp1, Operand(zero_reg));
-
- __ sll(temp1, slot, 1);
- __ Addu(temp1, temp1, vector);
- __ li(temp2, Operand(Smi::FromInt(kHasReturnedMinusZeroSentinel)));
- __ sw(temp2,
- FieldMemOperand(temp1, FixedArray::kHeaderSize + kPointerSize));
- }
-
- __ bind(&tail);
- // The slow case, we need this no matter what to complete a call after a miss.
- CallFunctionNoFeedback(masm, arg_count(), true, CallAsMethod());
-
- // Unreachable.
- __ stop("Unreachable");
-
- __ bind(&miss);
- GenerateMiss(masm);
- __ Branch(&tail);
-}
-
-
-void CallIC_CeilStub::Generate(MacroAssembler* masm) {
- Register function = a1;
- Register vector = a2;
- Register slot = a3;
-
- Register temp1 = a0;
- Register temp2 = t0;
- DoubleRegister double_temp1 = f12;
- DoubleRegister double_temp2 = f14;
- Label tail, miss;
-
- // Ensure nobody has snuck in another function.
- __ BranchIfNotBuiltin(function, temp1, kMathCeil, &miss);
-
- if (arg_count() > 0) {
- __ lw(temp1, MemOperand(sp, (arg_count() - 1) * kPointerSize));
- Handle<Map> map = isolate()->factory()->heap_number_map();
- __ CheckMap(temp1, temp2, map, &tail, DO_SMI_CHECK);
- __ ldc1(double_temp1, FieldMemOperand(temp1, HeapNumber::kValueOffset));
-
- // If the number is >0, it doesn't round to -0
- __ Move(double_temp2, 0.0);
- __ BranchF64(&tail, nullptr, gt, double_temp1, double_temp2);
-
- // If the number is <=-1, it doesn't round to -0
- __ Move(double_temp2, -1.0);
- __ BranchF64(&tail, nullptr, le, double_temp1, double_temp2);
-
- // +0 doesn't round to -0.
- __ FmoveHigh(temp1, double_temp1);
- __ Branch(&tail, ne, temp1, Operand(0x80000000));
-
- __ sll(temp1, slot, 1);
- __ Addu(temp1, temp1, vector);
- __ li(temp2, Operand(Smi::FromInt(kHasReturnedMinusZeroSentinel)));
- __ sw(temp2,
- FieldMemOperand(temp1, FixedArray::kHeaderSize + kPointerSize));
- }
-
- __ bind(&tail);
- // The slow case, we need this no matter what to complete a call after a miss.
- CallFunctionNoFeedback(masm, arg_count(), true, CallAsMethod());
-
- // Unreachable.
- __ stop("Unreachable");
-
- __ bind(&miss);
- GenerateMiss(masm);
- __ Branch(&tail);
-}
-
-
void CallICStub::Generate(MacroAssembler* masm) {
// a1 - function
// a3 - slot id (Smi)
@@ -3110,11 +2961,6 @@
// behavior on MISS.
__ LoadGlobalFunction(Context::ARRAY_FUNCTION_INDEX, t0);
__ Branch(&miss, eq, a1, Operand(t0));
-
- // Some builtin functions require special handling, miss to the runtime.
- __ lw(t0, FieldMemOperand(a1, JSFunction::kSharedFunctionInfoOffset));
- __ lw(t0, FieldMemOperand(t0, SharedFunctionInfo::kFunctionDataOffset));
- __ Branch(&miss, ne, t0, Operand(Smi::FromInt(0)));
// Update stats.
__ lw(t0, FieldMemOperand(a2, with_types_offset));
@@ -4740,27 +4586,6 @@
void CallIC_ArrayTrampolineStub::Generate(MacroAssembler* masm) {
EmitLoadTypeFeedbackVector(masm, a2);
CallIC_ArrayStub stub(isolate(), state());
- __ Jump(stub.GetCode(), RelocInfo::CODE_TARGET);
-}
-
-
-void CallIC_RoundTrampolineStub::Generate(MacroAssembler* masm) {
- EmitLoadTypeFeedbackVector(masm, a2);
- CallIC_RoundStub stub(isolate(), state());
- __ Jump(stub.GetCode(), RelocInfo::CODE_TARGET);
-}
-
-
-void CallIC_FloorTrampolineStub::Generate(MacroAssembler* masm) {
- EmitLoadTypeFeedbackVector(masm, a2);
- CallIC_FloorStub stub(isolate(), state());
- __ Jump(stub.GetCode(), RelocInfo::CODE_TARGET);
-}
-
-
-void CallIC_CeilTrampolineStub::Generate(MacroAssembler* masm) {
- EmitLoadTypeFeedbackVector(masm, a2);
- CallIC_CeilStub stub(isolate(), state());
__ Jump(stub.GetCode(), RelocInfo::CODE_TARGET);
}
« no previous file with comments | « src/math.js ('k') | src/mips/macro-assembler-mips.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698