Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Side by Side Diff: test/mjsunit/math-round-minus-zero.js

Issue 1115973005: Revert of Collect type feedback on result of Math.[round|ceil|floor] (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/math-floor-minus-zero.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are
4 // met:
5 //
6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission.
15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27
28 // Flags: --allow-natives-syntax --noalways-opt
29
30 // Test that a -0 result doesn't cause deopt loops
31 function noDeoptLoop(x) {
32 return Math.round(x);
33 }
34 assertEquals(0, noDeoptLoop(0.4));
35 assertEquals(0, noDeoptLoop(0.4));
36 assertEquals(0, noDeoptLoop(0.4));
37 %OptimizeFunctionOnNextCall(noDeoptLoop);
38 assertEquals(0, noDeoptLoop(0.4));
39 assertEquals(0, noDeoptLoop(0.4));
40 assertEquals(-Infinity, 1/noDeoptLoop(-0.4));
41 assertUnoptimized(noDeoptLoop);
42 assertEquals(-Infinity, 1/noDeoptLoop(-0.4));
43 assertEquals(-Infinity, 1/noDeoptLoop(-0.0));
44 assertEquals(-Infinity, 1/noDeoptLoop(-0.5));
45 assertEquals(-1, noDeoptLoop(-1));
46 assertEquals(-1, noDeoptLoop(-0.51));
47 %OptimizeFunctionOnNextCall(noDeoptLoop);
48 assertEquals(-Infinity, 1/noDeoptLoop(-0.4));
49 assertEquals(-Infinity, 1/noDeoptLoop(-0.4));
50 assertOptimized(noDeoptLoop);
51 %ClearFunctionTypeFeedback(noDeoptLoop);
52 %DeoptimizeFunction(noDeoptLoop);
53
54 // Test that round that goes megamorphic is handled correctly.
55 function notRound(x) {
56 return -x;
57 }
58 function testMega(f, x) {
59 return f(x);
60 }
61 assertEquals(7, testMega(Math.round, 7.4));
62 assertEquals(7, testMega(Math.round, 7.4));
63 assertEquals(7, testMega(Math.round, 7.4));
64 assertEquals(-7.4, testMega(notRound, 7.4));
65
66 // Make sure that we can learn about round specialization from Cranskhaft, which
67 // doesn't insert soft deopts for CallICs.
68 function crankRoundLearn(x) {
69 return Math.round(x);
70 }
71 %OptimizeFunctionOnNextCall(crankRoundLearn);
72 assertEquals(12, crankRoundLearn(12.3));
73 assertOptimized(crankRoundLearn);
74 assertEquals(-Infinity, 1/crankRoundLearn(-0.4));
75 assertOptimized(crankRoundLearn);
76 assertEquals(-Infinity, 1/crankRoundLearn(-0.4));
OLDNEW
« no previous file with comments | « test/mjsunit/math-floor-minus-zero.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698