Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1115973005: Revert of Collect type feedback on result of Math.[round|ceil|floor] (Closed)

Created:
5 years, 7 months ago by danno
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Collect type feedback on result of Math.[round|ceil|floor] (patchset #13 id:230001 of https://codereview.chromium.org/1053143005/) Reason for revert: All sorts of performance regressions Original issue's description: > Collect type feedback on result of Math.[round|ceil|floor] > > By recording invocations of these builtins that can return -0, we now learn to not emit Crankshaft code that only handles integer results, avoiding deopt loops. > > Committed: https://crrev.com/f36ecaf3a4d61568ca50a20718acce7dd5da9a5f > Cr-Commit-Position: refs/heads/master@{#28215} TBR=mvstanton@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a988d5f261ed9a8addcb02e327560329f0515649 Cr-Commit-Position: refs/heads/master@{#28237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1634 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +0 lines, -187 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 3 chunks +0 lines, -183 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/assembler.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/assembler.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M src/ast.h View 3 chunks +1 line, -10 lines 0 comments Download
M src/code-stubs.h View 5 chunks +0 lines, -80 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 5 chunks +11 lines, -56 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 3 chunks +0 lines, -179 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +1 line, -43 lines 0 comments Download
M src/math.js View 3 chunks +4 lines, -4 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 3 chunks +0 lines, -175 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 3 chunks +0 lines, -175 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/type-feedback-vector.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-feedback-vector.cc View 3 chunks +1 line, -12 lines 0 comments Download
M src/type-info.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M src/typing.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 3 chunks +0 lines, -181 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
D test/mjsunit/math-ceil-minus-zero.js View 1 chunk +0 lines, -75 lines 0 comments Download
D test/mjsunit/math-floor-minus-zero.js View 1 chunk +0 lines, -75 lines 0 comments Download
D test/mjsunit/math-round-minus-zero.js View 1 chunk +0 lines, -76 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
danno
Created Revert of Collect type feedback on result of Math.[round|ceil|floor]
5 years, 7 months ago (2015-05-05 16:41:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115973005/1
5 years, 7 months ago (2015-05-05 16:41:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 16:42:10 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 16:42:29 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a988d5f261ed9a8addcb02e327560329f0515649
Cr-Commit-Position: refs/heads/master@{#28237}

Powered by Google App Engine
This is Rietveld 408576698