Enable all of SVG for Slimming Paint.

Enable all of SVG for Slimming Paint.

Most tests are just rebaselines. Some are failures.

NOTRY=true
R=pdr@chromium.org,chrishtr@chromium.org
BUG=477743
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194815

[Stephen Chennney, 2015-04-30 18:09:21]

The CQ bit was checked by schenney@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-30 18:09:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115973004/1

[Stephen Chennney, 2015-04-30 18:10:10]

Enable all the SVG!

There are a few failures which we'll need to address. But we're mostly going to
rebaseline.

[Stephen Chennney, 2015-04-30 18:28:51]

The CQ bit was checked by schenney@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-30 18:29:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115973004/20001

[Xianzhu, 2015-04-30 18:46:09]

wangxianzhu@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[Xianzhu, 2015-04-30 18:46:11]

https://codereview.chromium.org/1115973004/diff/20001/LayoutTests/TestExpecta...
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1115973004/diff/20001/LayoutTests/TestExpecta...
LayoutTests/TestExpectations:2093: crbug.com/477763
virtual/slimmingpaint/svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg [ NeedsRebaseline
]
Is the bug number correct?

(Asking because there is no existing reference to this bug, but the bug looks
not a slimming-paint bug)

[Stephen Chennney, 2015-04-30 18:48:32]

On 2015/04/30 18:46:11, Xianzhu wrote:
>
https://codereview.chromium.org/1115973004/diff/20001/LayoutTests/TestExpecta...
> File LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/1115973004/diff/20001/LayoutTests/TestExpecta...
> LayoutTests/TestExpectations:2093: crbug.com/477763
> virtual/slimmingpaint/svg/W3C-SVG-1.1-SE/svgdom-over-01-f.svg [
NeedsRebaseline
> ]
> Is the bug number correct?
> 
> (Asking because there is no existing reference to this bug, but the bug looks
> not a slimming-paint bug)

Argh. 477743. I'll fix.

[chrishtr, 2015-04-30 20:18:19]

There seem to be some more failures based on the patchset 2 run. Could you also
put up a run demonstrating the rebaselines?

[pdr., 2015-04-30 20:24:47]

https://codereview.chromium.org/1115973004/diff/40001/LayoutTests/TestExpecta...
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1115973004/diff/40001/LayoutTests/TestExpecta...
LayoutTests/TestExpectations:2079: crbug.com/451606
virtual/slimmingpaint/svg/filters/feImage-target-add-to-document.svg [ Crash
Pass ]
Have you updated? These shouldn't be crashing.

[Stephen Chennney, 2015-04-30 20:29:08]

The CQ bit was checked by schenney@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-04-30 20:29:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115973004/60001

[Stephen Chennney, 2015-04-30 20:34:25]

RE Chris' question. I've updated for the bot results, being conservative where
there's potential flakiness. As I say below, I would really lke to land then
clean up as it's very hard to keep track with so many files.

The vast majority of the rebaselines are just adding in the invalidation
information that is now produced in text dumps. I'll try to get a link for you,
but putting them in the review will be enormous.

https://codereview.chromium.org/1115973004/diff/40001/LayoutTests/TestExpecta...
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/1115973004/diff/40001/LayoutTests/TestExpecta...
LayoutTests/TestExpectations:2079: crbug.com/451606
virtual/slimmingpaint/svg/filters/feImage-target-add-to-document.svg [ Crash
Pass ]
On 2015/04/30 20:24:47, pdr wrote:
> Have you updated? These shouldn't be crashing.

The bots didn't report them as unexpectedly not crashing, but maybe that's
because they are marked to flakey. I'd much rather clean up the list after the
rebaseline rather than try to sort it out among all the other files.

[Stephen Chennney, 2015-04-30 20:45:32]

https://codereview.chromium.org/1116933006 is a patch that should show all the
rebaseline results in the bot's "Archive Test Results" step. It probably won't
have them until after I go home for the day, but it would be good if you could
take look and get me feedback on this so I can commit tomorrow AM.

[pdr., 2015-04-30 20:56:22]

On 2015/04/30 at 20:34:25, schenney wrote:
>
https://codereview.chromium.org/1115973004/diff/40001/LayoutTests/TestExpecta...
> LayoutTests/TestExpectations:2079: crbug.com/451606
virtual/slimmingpaint/svg/filters/feImage-target-add-to-document.svg [ Crash
Pass ]
> On 2015/04/30 20:24:47, pdr wrote:
> > Have you updated? These shouldn't be crashing.
> 
> The bots didn't report them as unexpectedly not crashing, but maybe that's
because they are marked to flakey. I'd much rather clean up the list after the
rebaseline rather than try to sort it out among all the other files.

Can we remove them por favor?

[Stephen Chennney, 2015-04-30 21:09:41]

On 2015/04/30 20:56:22, pdr wrote:
> On 2015/04/30 at 20:34:25, schenney wrote:
> >
>
https://codereview.chromium.org/1115973004/diff/40001/LayoutTests/TestExpecta...
> > LayoutTests/TestExpectations:2079: crbug.com/451606
> virtual/slimmingpaint/svg/filters/feImage-target-add-to-document.svg [ Crash
> Pass ]
> > On 2015/04/30 20:24:47, pdr wrote:
> > > Have you updated? These shouldn't be crashing.
> > 
> > The bots didn't report them as unexpectedly not crashing, but maybe that's
> because they are marked to flakey. I'd much rather clean up the list after the
> rebaseline rather than try to sort it out among all the other files.
> 
> Can we remove them por favor?

Trying it out on the other patch, to verify.
https://codereview.chromium.org/1116933006

Based on that I'll adjust them back here.

[commit-bot: I haz the power, 2015-04-30 22:11:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-30 22:11:08]

Dry run: This issue passed the CQ dry run.

[Stephen Chennney, 2015-04-30 23:20:25]

The other bot tells us that we have the feImage tests covered so I will remove
them before committing. But I can't do that tonight. The last CQ run here
indicates we got all the failures.

Can I get an l g t m knowing that I will remove the passing tests before
committing tomorrow? Otherwise we're stuck while I go on vacation (or someone
else has to work through the hassle of doing this).

[pdr., 2015-04-30 23:56:50]

On 2015/04/30 at 23:20:25, schenney wrote:
> The other bot tells us that we have the feImage tests covered so I will remove
them before committing. But I can't do that tonight. The last CQ run here
indicates we got all the failures.
> 
> Can I get an l g t m knowing that I will remove the passing tests before
committing tomorrow? Otherwise we're stuck while I go on vacation (or someone
else has to work through the hassle of doing this).

LGTM, sounds good to me.

[Stephen Chennney, 2015-05-01 15:49:36]

The CQ bit was checked by schenney@chromium.org

[Stephen Chennney, 2015-05-01 15:49:37]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1115973004/#ps80001
(title: "Rebased and removed passing tests.")

[commit-bot: I haz the power, 2015-05-01 15:49:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115973004/80001

[Stephen Chennney, 2015-05-01 17:22:34]

The CQ bit was checked by schenney@chromium.org

[Stephen Chennney, 2015-05-01 17:22:34]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1115973004/#ps100001
(title: "Fix expectations")

[commit-bot: I haz the power, 2015-05-01 17:23:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1115973004/100001

[commit-bot: I haz the power, 2015-05-01 17:37:30]

Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194815