Source/modules/geolocation/Geolocation.cpp - Issue 1115913002: Add deprecation warnings to old powerful features on insecure origins.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geolocation/Geolocation.cpp

Issue 1115913002: Add deprecation warnings to old powerful features on insecure origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updates from nits Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/UseCounter.cpp ('K') | « Source/modules/device_orientation/DeviceOrientationController.cpp ('k') | Source/modules/mediastream/NavigatorMediaStream.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/geolocation/Geolocation.cpp

diff --git a/Source/modules/geolocation/Geolocation.cpp b/Source/modules/geolocation/Geolocation.cpp

index 315053dd0080901e1f94ec5aeb86314297402cee..59a8a3d91aa38c11cec7ab7e1dd792dd387f4182 100644

--- a/Source/modules/geolocation/Geolocation.cpp

+++ b/Source/modules/geolocation/Geolocation.cpp

@@ -152,10 +152,10 @@ void Geolocation::recordOriginTypeAccess() const

// actually used. This could be used later if a warning is shown in the

// developer console.

String insecureOriginMsg;

- UseCounter::Feature counter = document->isPrivilegedContext(insecureOriginMsg)

- ? UseCounter::GeolocationSecureOrigin

- : UseCounter::GeolocationInsecureOrigin;

- UseCounter::count(document, counter);

+ if (document->isPrivilegedContext(insecureOriginMsg))

+ UseCounter::count(document, UseCounter::GeolocationSecureOrigin);

+ else

+ UseCounter::countDeprecation(document, UseCounter::GeolocationInsecureOrigin);

}

void Geolocation::getCurrentPosition(PositionCallback* successCallback, PositionErrorCallback* errorCallback, const PositionOptions& options)