Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: Source/core/dom/Fullscreen.cpp

Issue 1115913002: Add deprecation warnings to old powerful features on insecure origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updates from nits Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Fullscreen.cpp
diff --git a/Source/core/dom/Fullscreen.cpp b/Source/core/dom/Fullscreen.cpp
index 552abaaa706744252e467126c67bdaaa4c3dd2ef..48056019a28429f8e6af8727a4d40e244980b93f 100644
--- a/Source/core/dom/Fullscreen.cpp
+++ b/Source/core/dom/Fullscreen.cpp
@@ -204,6 +204,15 @@ void Fullscreen::documentWasDisposed()
void Fullscreen::requestFullscreen(Element& element, RequestType requestType)
{
+ // It is required by isPrivilegedContext() but isn't
+ // actually used. This could be used later if a warning is shown in the
philipj_slow 2015/05/01 22:36:58 The countDeprecation is the console warning, is th
jww 2015/05/05 21:29:53 I think that's an accurate description of where it
philipj_slow 2015/05/06 07:43:55 The fullscreen element ready check is only used in
+ // developer console.
+ String errorMessage;
+ if (document()->isPrivilegedContext(errorMessage))
+ UseCounter::count(document(), UseCounter::FullscreenSecureOrigin);
+ else
+ UseCounter::countDeprecation(document(), UseCounter::FullscreenInsecureOrigin);
+
// Ignore this request if the document is not in a live frame.
if (!document()->isActive())
return;

Powered by Google App Engine
This is Rietveld 408576698