Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 1115913002: Add deprecation warnings to old powerful features on insecure origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Updates from nits Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 881 matching lines...) Expand 10 before | Expand all | Expand 10 after
892 case ServiceWorkerClientPostMessage: 892 case ServiceWorkerClientPostMessage:
893 return "'Client.postMessage()' is an experimental API and may change. Se e https://github.com/slightlyoff/ServiceWorker/issues/609."; 893 return "'Client.postMessage()' is an experimental API and may change. Se e https://github.com/slightlyoff/ServiceWorker/issues/609.";
894 894
895 case AttrChildAccess: 895 case AttrChildAccess:
896 case AttrChildChange: 896 case AttrChildChange:
897 return "Attr child nodes are deprecated and will be removed in M45, arou nd August 2015. Please use 'Attr.value' instead."; 897 return "Attr child nodes are deprecated and will be removed in M45, arou nd August 2015. Please use 'Attr.value' instead.";
898 898
899 case CSSKeyframesRuleInsertRule: 899 case CSSKeyframesRuleInsertRule:
900 return "'CSSKeyframesRule.insertRule()' is deprecated and will be remove d in M45, around August 2015. Please use 'CSSKeyframesRule.appendRule()' instead ."; 900 return "'CSSKeyframesRule.insertRule()' is deprecated and will be remove d in M45, around August 2015. Please use 'CSSKeyframesRule.appendRule()' instead .";
901 901
902 // Powerful features on insecure origins (https://goo.gl/rStTGz)
903 case GeolocationInsecureOrigin:
904 return "Geolocation via getCurrentPosition() and watchPosition() will be deprecated over insecure origins in the future. You should consider switching y our application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";
905
906 case GetUserMediaInsecureOrigin:
907 return "getUserMedia() will be deprecated over insecure origins in the f uture. You should consider switching your application to a secure origin, such a s HTTPS. See https://goo.gl/rStTGz for more details.";
908
909 case DeviceMotionInsecureOrigin:
philipj_slow 2015/05/01 22:36:58 The DeviceMotionInsecureOrigin and DeviceOrientati
jww 2015/05/05 21:29:53 That's a great point, and my mistake for not check
philipj_slow 2015/05/06 07:43:55 Thanks!
910 return "The 'devicemotion' event will be deprecated over insecure origin s in the future. You should consider switching your application to a secure orig in, such as HTTPS. See https://goo.gl/rStTGz for more details.";
911
912 case DeviceOrientationInsecureOrigin:
913 return "The 'deviceorientation' event will be deprecated over insecure o rigins in the future. You should consider switching your application to a secure origin, such as HTTPS. See https://goo.gl/rStTGz for more details.";
914
915 case FullscreenInsecureOrigin:
916 return "requestFullscreen() will be deprecated over insecure origins in the future. You should consider switching your application to a secure origin, s uch as HTTPS. See https://goo.gl/rStTGz for more details.";
917
902 // Features that aren't deprecated don't have a deprecation message. 918 // Features that aren't deprecated don't have a deprecation message.
903 default: 919 default:
904 return String(); 920 return String();
905 } 921 }
906 } 922 }
907 923
908 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 924 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
909 { 925 {
910 ASSERT(feature >= firstCSSProperty); 926 ASSERT(feature >= firstCSSProperty);
911 ASSERT(feature <= lastUnresolvedCSSProperty); 927 ASSERT(feature <= lastUnresolvedCSSProperty);
(...skipping 27 matching lines...) Expand all
939 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 955 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
940 { 956 {
941 // FIXME: We may want to handle stylesheets that have multiple owners 957 // FIXME: We may want to handle stylesheets that have multiple owners
942 // http://crbug.com/242125 958 // http://crbug.com/242125
943 if (sheetContents && sheetContents->hasSingleOwnerNode()) 959 if (sheetContents && sheetContents->hasSingleOwnerNode())
944 return getFrom(sheetContents->singleOwnerDocument()); 960 return getFrom(sheetContents->singleOwnerDocument());
945 return 0; 961 return 0;
946 } 962 }
947 963
948 } // namespace blink 964 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698