Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: Source/core/dom/Fullscreen.cpp

Issue 1115913002: Add deprecation warnings to old powerful features on insecure origins. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase on ToT Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2013 Google Inc. All rights reserved. 9 * Copyright (C) 2013 Google Inc. All rights reserved.
10 * 10 *
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 { 197 {
198 // NOTE: the context dispose phase is not supported in oilpan. Please 198 // NOTE: the context dispose phase is not supported in oilpan. Please
199 // consider using the detach phase instead. 199 // consider using the detach phase instead.
200 m_fullScreenElement = nullptr; 200 m_fullScreenElement = nullptr;
201 m_fullScreenElementStack.clear(); 201 m_fullScreenElementStack.clear();
202 } 202 }
203 #endif 203 #endif
204 204
205 void Fullscreen::requestFullscreen(Element& element, RequestType requestType) 205 void Fullscreen::requestFullscreen(Element& element, RequestType requestType)
206 { 206 {
207 // It is required by isPrivilegedContext() but isn't
208 // actually used. This could be used later if a warning is shown in the
209 // developer console.
210 String errorMessage;
211 if (document()->isPrivilegedContext(errorMessage)) {
212 UseCounter::count(document(), UseCounter::FullscreenSecureOrigin);
213 } else {
214 UseCounter::countDeprecation(document(), UseCounter::FullscreenInsecureO rigin);
215 }
mlamouri (slow - plz ping) 2015/04/30 05:23:53 No need for { and }
jww 2015/04/30 17:28:44 Done.
216 // logPowerfulFeatureInsecureOriginWarning(document(), "fullscreen");
217 //}
mlamouri (slow - plz ping) 2015/04/30 05:23:53 Remove?
jww 2015/04/30 17:28:45 Yikes, sorry! Done.
218
207 // Ignore this request if the document is not in a live frame. 219 // Ignore this request if the document is not in a live frame.
208 if (!document()->isActive()) 220 if (!document()->isActive())
209 return; 221 return;
210 222
211 // If |element| is on top of |doc|'s fullscreen element stack, terminate the se substeps. 223 // If |element| is on top of |doc|'s fullscreen element stack, terminate the se substeps.
212 if (&element == fullscreenElement()) 224 if (&element == fullscreenElement())
213 return; 225 return;
214 226
215 do { 227 do {
216 // 1. If any of the following conditions are true, terminate these steps and queue a task to fire 228 // 1. If any of the following conditions are true, terminate these steps and queue a task to fire
(...skipping 389 matching lines...) Expand 10 before | Expand all | Expand 10 after
606 DEFINE_TRACE(Fullscreen) 618 DEFINE_TRACE(Fullscreen)
607 { 619 {
608 visitor->trace(m_fullScreenElement); 620 visitor->trace(m_fullScreenElement);
609 visitor->trace(m_fullScreenElementStack); 621 visitor->trace(m_fullScreenElementStack);
610 visitor->trace(m_eventQueue); 622 visitor->trace(m_eventQueue);
611 WillBeHeapSupplement<Document>::trace(visitor); 623 WillBeHeapSupplement<Document>::trace(visitor);
612 DocumentLifecycleObserver::trace(visitor); 624 DocumentLifecycleObserver::trace(visitor);
613 } 625 }
614 626
615 } // namespace blink 627 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698