net/socket/ssl_client_socket_nss.h - Issue 1115903002: Refactor the API for CertVerifier::Verify() and the implementation of MultiThreadedCertVerifier::Ver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_nss.h

Issue 1115903002: Refactor the API for CertVerifier::Verify() and the implementation of MultiThreadedCertVerifier::Ver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: more chromeos stuff Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/cert/multi_threaded_cert_verifier.cc ('K') | « net/quic/crypto/proof_verifier_chromium.cc ('k') | net/socket/ssl_client_socket_nss.cc » ('j') | tools/valgrind/memcheck/suppressions.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/socket/ssl_client_socket_nss.h

diff --git a/net/socket/ssl_client_socket_nss.h b/net/socket/ssl_client_socket_nss.h

index e348ebc93193de05e4b5e2f09f687e1838d1ccad..97bcb032644ebc5347a9f75b7d54ffb20f4a35cb 100644

--- a/net/socket/ssl_client_socket_nss.h

+++ b/net/socket/ssl_client_socket_nss.h

@@ -21,6 +21,7 @@

#include "net/base/host_port_pair.h"

#include "net/base/net_export.h"

#include "net/base/nss_memio.h"

+#include "net/cert/cert_verifier.h"

#include "net/cert/cert_verify_result.h"

#include "net/cert/ct_verify_result.h"

#include "net/cert/x509_certificate.h"

@@ -41,7 +42,6 @@ class CertVerifier;

class ChannelIDService;

class CTVerifier;

class ClientSocketHandle;

-class SingleRequestCertVerifier;

class TransportSecurityState;

class X509Certificate;

@@ -167,7 +167,7 @@ class SSLClientSocketNSS : public SSLClientSocket {

CertVerifyResult server_cert_verify_result_;

CertVerifier* const cert_verifier_;

- scoped_ptr<SingleRequestCertVerifier> verifier_;

+ scoped_ptr<CertVerifier::Request> cert_verifier_request_;

// Certificate Transparency: Verifier and result holder.

ct::CTVerifyResult ct_verify_result_;