Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: pkg/analysis_server/lib/src/services/completion/completion_manager.dart

Issue 1115843003: restructure internal request to implement CompletionRequest API, (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/completion/completion_manager.dart
diff --git a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
index 5ed7b1abe5d66fd574ae0359beb073b49667ebef..1680f2b1010cd34f201598736523edac37fe99dc 100644
--- a/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
+++ b/pkg/analysis_server/lib/src/services/completion/completion_manager.dart
@@ -6,9 +6,13 @@ library services.completion.manager;
import 'dart:async';
+import 'package:analysis_server/completion/completion_core.dart'
+ show CompletionRequest;
+import 'package:analysis_server/src/analysis_server.dart';
import 'package:analysis_server/src/protocol.dart';
import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
import 'package:analysis_server/src/services/search/search_engine.dart';
+import 'package:analyzer/file_system/file_system.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/source.dart';
@@ -130,10 +134,6 @@ class CompletionPerformance {
_stopwatch.start();
}
- void setContentsAndOffset(String contents, int offset) {
- snippet = _computeSnippet(contents, offset);
- }
-
int get elapsedInMilliseconds =>
operations.length > 0 ? operations.last.elapsed.inMilliseconds : 0;
@@ -181,6 +181,10 @@ class CompletionPerformance {
_startTimes[tag] = _stopwatch.elapsed;
}
+ void setContentsAndOffset(String contents, int offset) {
+ snippet = _computeSnippet(contents, offset);
+ }
+
void _logDuration(String tag, Duration elapsed) {
operations.add(new OperationPerformance(tag, elapsed));
}
@@ -217,18 +221,26 @@ class CompletionPerformance {
/**
* Encapsulates information specific to a particular completion request.
*/
-class CompletionRequest {
+class CompletionRequestImpl implements CompletionRequest {
+
/**
- * The offset within the source at which the completion is requested.
+ * The underlying analysis server for this completion request.
*/
+ final AnalysisServer server;
+
+ @override
+ final AnalysisContext context;
+
+ @override
+ final Source source;
+
+ @override
final int offset;
- /**
- * Performance measurements for this particular request.
- */
- final CompletionPerformance performance;
+ CompletionRequestImpl(this.server, this.context, this.source, this.offset);
- CompletionRequest(this.offset, this.performance);
+ @override
+ ResourceProvider get provider => server.resourceProvider;
}
/**

Powered by Google App Engine
This is Rietveld 408576698