restructure internal request to implement CompletionRequest API,

pkg/analysis_server/lib/completion/completion_core.dart

Index: pkg/analysis_server/lib/completion/completion_core.dart
diff --git a/pkg/analysis_server/lib/completion/completion_core.dart b/pkg/analysis_server/lib/completion/completion_core.dart
index d1aca7ae2a0b8d7316fabc5675ec4395681884cd..e4ce2c834cbdc0a3fcd7259e223273b1b97a6aec 100644
--- a/pkg/analysis_server/lib/completion/completion_core.dart
+++ b/pkg/analysis_server/lib/completion/completion_core.dart
@@ -5,6 +5,7 @@
 library analysis_server.completion.completion_core;
 
 import 'package:analysis_server/src/protocol.dart';
+import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/source.dart';
 
@@ -32,6 +33,13 @@ abstract class CompletionContributor {
  */
 abstract class CompletionRequest {
   /**
+   * Return the results that were returned the last time the contributor was
+   * asked for results, or `null` if this is the first request for results at
+   * this location.
+   */
+  //CompletionResult get previousResults;

[Brian Wilkerson, 2015/04/30 04:01:22]

I'm confused by this. If you're proposing that we drop the method, then we
should remove it. If you just can't implement it yet, perhaps it would be better
to leave it in the interface and implement it to throw an exception.

[danrubel, 2015/04/30 05:03:11]

I'm not sure so I commented it out. As mentioned above, this is step 1 of 4 or
5, so I'll clean it up as part of this process.

+
+  /**
    * Return the analysis context in which the completion is being requested.
    */
   AnalysisContext get context;
@@ -42,11 +50,9 @@ abstract class CompletionRequest {
   int get offset;
 
   /**
-   * Return the results that were returned the last time the contributor was
-   * asked for results, or `null` if this is the first request for results at
-   * this location.
+   * Return the resource provider associated with this request.
    */
-  CompletionResult get previousResults;
+  ResourceProvider get provider;

[Brian Wilkerson, 2015/04/30 04:01:22]

The name 'provider' is fairly generic. Perhaps 'resourceProvider' to be
consistent with AnalysisServer (which I think will also end up being public API
at some point)?

[danrubel, 2015/04/30 05:03:11]

Good point. Renamed.

 
   /**
    * Return the source in which the completion is being requested.