Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1115793002: Cleanup ARM trusted-toolchain-creator scripts (Closed)

Created:
5 years, 7 months ago by Sam Clegg
Modified:
5 years, 7 months ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Cleanup ARM trusted-toolchain-creator scripts Always use 'out' as working tree for creating sysroot image and always great consistently names tar archive (rather than asking the use for name on as $1) This initial change makes the two scripts largly identical. Next, I plan to merge them into a single script. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4157 R=bradnelson@google.com Committed: https://chromium.googlesource.com/native_client/src/native_client/+/d98a8f5ffed461a069683efbf29f3b1b2022ad0b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -85 lines) Patch
M tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.precise.sh View 9 chunks +32 lines, -50 lines 0 comments Download
M tools/trusted_cross_toolchains/trusted-toolchain-creator.armhf.trusty.sh View 10 chunks +22 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Sam Clegg
5 years, 7 months ago (2015-04-29 18:57:56 UTC) #2
bradn
lgtm
5 years, 7 months ago (2015-04-29 19:31:33 UTC) #4
Sam Clegg
5 years, 7 months ago (2015-04-29 19:32:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d98a8f5ffed461a069683efbf29f3b1b2022ad0b (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698