Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1115773002: Apply automated fixits for Chrome clang plugin to remoting. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 7 months ago
Reviewers:
Nico, Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply automated fixits for Chrome clang plugin to remoting. Working on trimming down plugin warnings on the Windows clang build. BUG=467287 TBR=jamiewalch@chromium.org Committed: https://crrev.com/a69265d0305aa682fe5a4b04a18d5f19e3e9969e Cr-Commit-Position: refs/heads/master@{#327548}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M remoting/host/desktop_shape_tracker_win.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M remoting/host/local_input_monitor_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/rdp_client_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/rdp_client_window.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/rdp_desktop_session.h View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
5 years, 7 months ago (2015-04-29 18:56:37 UTC) #2
Nico
lgtm
5 years, 7 months ago (2015-04-29 19:02:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115773002/1
5 years, 7 months ago (2015-04-29 19:04:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 19:36:18 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 19:37:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a69265d0305aa682fe5a4b04a18d5f19e3e9969e
Cr-Commit-Position: refs/heads/master@{#327548}

Powered by Google App Engine
This is Rietveld 408576698