Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1115763002: Apply automated fixits for Chrome clang plugin to cloud_print. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Apply automated fixits for Chrome clang plugin to cloud_print. Working on trimming down plugin warnings on the Windows clang build. BUG=467287 TBR=vitalybuka Committed: https://crrev.com/cb91176fc71741eebaf67b2f6af88f28cec5fadc Cr-Commit-Position: refs/heads/master@{#327561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M cloud_print/gcp20/prototype/cloud_print_requester.h View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
5 years, 7 months ago (2015-04-29 18:53:54 UTC) #2
Nico
lgtm
5 years, 7 months ago (2015-04-29 18:59:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115763002/1
5 years, 7 months ago (2015-04-29 19:00:11 UTC) #5
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 7 months ago (2015-04-29 21:29:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 21:31:33 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 21:33:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb91176fc71741eebaf67b2f6af88f28cec5fadc
Cr-Commit-Position: refs/heads/master@{#327561}

Powered by Google App Engine
This is Rietveld 408576698