Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1115663002: [storage/browser/fileapi] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in storage/browser/fileapi module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/127a5db6cccb2bc655940a91ecd3ec500703b255 Cr-Commit-Position: refs/heads/master@{#327648}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M storage/browser/fileapi/file_system_context.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_runner.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M storage/browser/fileapi/isolated_file_system_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/plugin_private_file_system_backend.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M storage/browser/fileapi/recursive_operation_delegate.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-04-29 12:10:50 UTC) #2
piman
lgtm
5 years, 7 months ago (2015-04-29 23:21:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115663002/1
5 years, 7 months ago (2015-04-30 02:40:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 03:43:05 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 03:44:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/127a5db6cccb2bc655940a91ecd3ec500703b255
Cr-Commit-Position: refs/heads/master@{#327648}

Powered by Google App Engine
This is Rietveld 408576698