Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 1115643002: Revert "Move JUnit to 'unix' condition in DEPS." (Closed)

Created:
5 years, 7 months ago by kjellander_chromium
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Move JUnit to 'unix' condition in DEPS." Reason: the GYP includes in src/third_party/junit/junit.gyp quickly goes into Android-only terroritory so reusing the target on non-Android would require a lot more work. This reverts the DEPS change in commit 0cb254911980cce90b2e5c7207a37a27420e9ea7. The checklicenses.py change is left in, since it makes sense to have it even if the code is only checked out for Android. BUG=webrtc:4499 TBR=jbudorick@chromium.org, phajdan.jr@chromium.org Committed: https://crrev.com/c1be0427a92b037a4fdbc44e4cca3f42e68bd8a9 Cr-Commit-Position: refs/heads/master@{#327478}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_chromium
5 years, 7 months ago (2015-04-29 11:20:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115643002/1
5 years, 7 months ago (2015-04-29 11:20:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 12:42:40 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 12:43:30 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1be0427a92b037a4fdbc44e4cca3f42e68bd8a9
Cr-Commit-Position: refs/heads/master@{#327478}

Powered by Google App Engine
This is Rietveld 408576698