Test Keeping NaCl plugins used in app background pages alive when active.

chrome/browser/extensions/app_background_page_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/path_service.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/background/background_contents_service.h"
 #include "chrome/browser/background/background_contents_service_factory.h"
 #include "chrome/browser/background/background_mode_manager.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/extensions/extension_test_message_listener.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_dialogs.h"
 #include "chrome/browser/ui/browser_window.h"
+#include "chrome/browser/ui/extensions/application_launch.h"
+#include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/test/test_notification_tracker.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/switches.h"
 #include "net/dns/mock_host_resolver.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
+#include "ppapi/shared_impl/ppapi_switches.h"
 
 #if defined(OS_MACOSX)
 #include "base/mac/scoped_nsautorelease_pool.h"
 #endif
 
 using extensions::Extension;
 
 class AppBackgroundPageApiTest : public ExtensionApiTest {
  public:
   virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
@@ skipping 65 matching lines @@
   void UnloadExtensionViaTask(const std::string& id) {
     base::MessageLoop::current()->PostTask(
         FROM_HERE,
         base::Bind(&AppBackgroundPageApiTest::UnloadExtension, this, id));
   }
 
  private:
   base::ScopedTempDir app_dir_;
 };
 
+namespace {

[yzshen1, 2013/12/14 01:07:01]

Is there any reason that this namespace covers the class below but not the one
above?

[scheib, 2013/12/14 05:43:50]

Yes, the above class is given Friend access outside of this compilation unit.

+
+// Fixture to assist in testing v2 app background pages containing
+// Native Client embeds.
+class AppBackgroundPageNaClTest : public AppBackgroundPageApiTest {
+ public:
+  AppBackgroundPageNaClTest()
+      : extension_(NULL) {
+    PathService::Get(chrome::DIR_GEN_TEST_DATA, &app_dir_);
+    app_dir_ = app_dir_.AppendASCII(
+        "ppapi/tests/extensions/background_keepalive/newlib");
+  }
+  virtual ~AppBackgroundPageNaClTest() {
+  }
+
+  virtual void SetUpCommandLine(CommandLine* command_line) OVERRIDE {
+    AppBackgroundPageApiTest::SetUpCommandLine(command_line);
+    command_line->AppendSwitchASCII(
+        switches::kPpapiKeepAliveThrottle, "50");
+    command_line->AppendSwitchASCII(
+        extensions::switches::kEventPageIdleTime, "1000");
+    command_line->AppendSwitchASCII(
+        extensions::switches::kEventPageSuspendingTime, "1000");
+  }
+
+  const Extension* extension() { return extension_; }
+
+ protected:
+  void LaunchTestingApp() {
+    extension_ = LoadExtension(app_dir_);
+    ASSERT_TRUE(extension_);
+  }
+
+ private:
+  base::FilePath app_dir_;
+  const Extension* extension_;
+};
+
+// Produces an extensions::ProcessManager::ImpulseCallbackForTesting callback
+// that will match a specified goal and can be waited on.
+class ImpulseCallbackCounter {
+ public:
+  explicit ImpulseCallbackCounter(const std::string& extension_id)
+      : observed_(0),
+        goal_(0),
+        extension_id_(extension_id) {
+  }
+
+  const extensions::ProcessManager::ImpulseCallbackForTesting

[yzshen1, 2013/12/14 01:07:01]

nit: this return value doesn't need to be const

[scheib, 2013/12/14 05:43:50]

Done.

+      SetGoalAndGetCallback(int goal) {
+    observed_ = 0;
+    goal_ = goal;
+    message_loop_runner_ = new content::MessageLoopRunner();
+    return base::Bind(&ImpulseCallbackCounter::ImpulseCallback,
+                      base::Unretained(this),
+                      message_loop_runner_->QuitClosure(),
+                      extension_id_);
+  }
+
+  void Wait() {
+    message_loop_runner_->Run();
+  }
+ private:
+  void ImpulseCallback(base::Closure quit_callback,

[yzshen1, 2013/12/14 01:07:01]

const &, and please move it to the next line.

[scheib, 2013/12/14 05:43:50]

Done.

+      const std::string& extension_id_from_test,
+      const std::string& extension_id_from_manager) {
+    if (extension_id_from_test == extension_id_from_manager) {
+      if (++observed_ >= goal_) {
+        quit_callback.Run();
+      }
+    }
+  }
+
+  int observed_;
+  int goal_;
+  const std::string extension_id_;
+  scoped_refptr<content::MessageLoopRunner> message_loop_runner_;
+};
+
+}  // namespace
+
 // Disable on Mac only.  http://crbug.com/95139
 #if defined(OS_MACOSX)
 #define MAYBE_Basic DISABLED_Basic
 #else
 #define MAYBE_Basic Basic
 #endif
 
 IN_PROC_BROWSER_TEST_F(AppBackgroundPageApiTest, MAYBE_Basic) {
   host_resolver()->AddRule("a.com", "127.0.0.1");
   ASSERT_TRUE(StartEmbeddedTestServer());
@@ skipping 374 matching lines @@
   // Close all browsers - app should continue running.
   set_exit_when_last_browser_closes(false);
   CloseBrowser(browser());
 
   // Post a task to unload the extension - this should cause Chrome to exit
   // cleanly (not crash).
   UnloadExtensionViaTask(extension->id());
   content::RunAllPendingInMessageLoop();
   ASSERT_TRUE(WaitForBackgroundMode(false));
 }
+
+// Verify active NaCl embeds cause many keepalive impulses to be sent.
+IN_PROC_BROWSER_TEST_F(AppBackgroundPageNaClTest, BackgroundKeepaliveActive) {
+  ExtensionTestMessageListener nacl_modules_loaded("nacl_modules_loaded", true);
+  LaunchTestingApp();
+  extensions::ProcessManager* manager =
+    extensions::ExtensionSystem::Get(browser()->profile())->process_manager();
+  ImpulseCallbackCounter active_impulse_counter(extension()->id());
+  EXPECT_TRUE(nacl_modules_loaded.WaitUntilSatisfied());
+
+  // Target 1 second: 1 second / 50ms throttle * 2 embeds == 40 impulses.
+  manager->SetKeepaliveImpulseCallbackForTesting(
+      active_impulse_counter.SetGoalAndGetCallback(40));

[yzshen1, 2013/12/14 01:07:01]

Is 1 second too long for a single test? Maybe we can make it shorter?

[scheib, 2013/12/14 05:43:50]

Done. Changed to 20 ~~ .5 seconds. This is fairly small for the overhead of
bringing a browser test up, but still long enough to ensure we're seeing
sustained behavior.

+  active_impulse_counter.Wait();
+}
+
+// Verify that nacl modules that go idle will not send keepalive impulses.
+IN_PROC_BROWSER_TEST_F(AppBackgroundPageNaClTest, BackgroundKeepaliveIdle) {
+  ExtensionTestMessageListener nacl_modules_loaded("nacl_modules_loaded", true);
+  LaunchTestingApp();
+  extensions::ProcessManager* manager =
+    extensions::ExtensionSystem::Get(browser()->profile())->process_manager();
+  ImpulseCallbackCounter idle_impulse_counter(extension()->id());
+  EXPECT_TRUE(nacl_modules_loaded.WaitUntilSatisfied());
+
+  manager->SetKeepaliveImpulseDecrementCallbackForTesting(
+      idle_impulse_counter.SetGoalAndGetCallback(1));
+  nacl_modules_loaded.Reply("be idle");
+  idle_impulse_counter.Wait();
+}
+