Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1187)

Issue 1115623002: Removing blink::prefix (Closed)

Created:
5 years, 7 months ago by a.berwal
Modified:
5 years, 7 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removing blink::prefix Removing blink::prefix in Source/build/* whereever it is not needed. BUG=477256 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194651

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/build/mac/Prefix.h View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 9 (2 generated)
a.berwal
PTAL
5 years, 7 months ago (2015-04-29 09:11:27 UTC) #2
haraken
LGTM
5 years, 7 months ago (2015-04-29 11:30:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115623002/1
5 years, 7 months ago (2015-04-29 11:31:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194651
5 years, 7 months ago (2015-04-29 12:51:50 UTC) #6
tkent
https://codereview.chromium.org/1115623002/diff/1/Source/build/mac/Prefix.h File Source/build/mac/Prefix.h (right): https://codereview.chromium.org/1115623002/diff/1/Source/build/mac/Prefix.h#newcode67 Source/build/mac/Prefix.h:67: const TimerHeapReference& move(const TimerHeapReference& t) Here is not in ...
5 years, 7 months ago (2015-04-29 20:22:36 UTC) #7
tkent
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1115603005/ by tkent@chromium.org. ...
5 years, 7 months ago (2015-04-29 20:23:21 UTC) #8
tkent
5 years, 7 months ago (2015-04-30 02:18:14 UTC) #9
Message was sent while issue was closed.
According to WebKit, this part is unnecessary since Mountain Lion.

http://trac.webkit.org/changeset/177249/trunk/Source/WebCore/WebCorePrefix.h

I don't know if we use libc++ or libstdc++.

Powered by Google App Engine
This is Rietveld 408576698