Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1115613002: [turbofan] Correctly handle illegal redeclarations. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Correctly handle illegal redeclarations. R=titzer@chromium.org TEST=mjsunit/const-redecl Committed: https://crrev.com/e7292b3c1a0b79b1953d95b52e2f5f7bd58b9d1a Cr-Commit-Position: refs/heads/master@{#28125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/compiler.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 7 months ago (2015-04-29 09:02:05 UTC) #1
titzer
lgtm
5 years, 7 months ago (2015-04-29 09:07:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115613002/1
5 years, 7 months ago (2015-04-29 09:08:23 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 09:22:40 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 09:22:57 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7292b3c1a0b79b1953d95b52e2f5f7bd58b9d1a
Cr-Commit-Position: refs/heads/master@{#28125}

Powered by Google App Engine
This is Rietveld 408576698