Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1115603005: Revert of Removing blink::prefix (Closed)

Created:
5 years, 7 months ago by tkent
Modified:
5 years, 7 months ago
Reviewers:
haraken, a.berwal
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Removing blink::prefix (patchset #1 id:1 of https://codereview.chromium.org/1115623002/) Reason for revert: We can't remove blink:: here. Original issue's description: > Removing blink::prefix > > Removing blink::prefix in Source/build/* whereever it is not needed. > > BUG=477256 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194651 TBR=haraken@chromium.org,a.berwal@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477256 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/build/mac/Prefix.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of Removing blink::prefix
5 years, 7 months ago (2015-04-29 20:23:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115603005/1
5 years, 7 months ago (2015-04-29 20:24:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194670
5 years, 7 months ago (2015-04-29 20:24:47 UTC) #3
haraken
5 years, 7 months ago (2015-04-30 00:50:06 UTC) #4
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698