Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1115603003: [test] Remove deprecated cctest/test-node-algorithm tests. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Remove deprecated cctest/test-node-algorithm tests. R=jarin@chromium.org TEST=cctest/test-graph-visualizer Committed: https://crrev.com/58b0023fa8dfd3b1a3216d7ce4685ceb39c7572e Cr-Commit-Position: refs/heads/master@{#28134}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -59 lines) Patch
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/compiler/graph-tester.h View 1 chunk +3 lines, -18 lines 2 comments Download
M test/cctest/compiler/test-graph-visualizer.cc View 2 chunks +32 lines, -0 lines 0 comments Download
D test/cctest/compiler/test-node-algorithm.cc View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 7 months ago (2015-04-29 09:33:30 UTC) #1
Jarin
lgtm. https://codereview.chromium.org/1115603003/diff/1/test/cctest/compiler/graph-tester.h File test/cctest/compiler/graph-tester.h (right): https://codereview.chromium.org/1115603003/diff/1/test/cctest/compiler/graph-tester.h#newcode18 test/cctest/compiler/graph-tester.h:18: class GraphTester : public HandleAndZoneScope, public Graph { ...
5 years, 7 months ago (2015-04-29 14:01:05 UTC) #3
Michael Starzinger
https://codereview.chromium.org/1115603003/diff/1/test/cctest/compiler/graph-tester.h File test/cctest/compiler/graph-tester.h (right): https://codereview.chromium.org/1115603003/diff/1/test/cctest/compiler/graph-tester.h#newcode18 test/cctest/compiler/graph-tester.h:18: class GraphTester : public HandleAndZoneScope, public Graph { On ...
5 years, 7 months ago (2015-04-29 14:11:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115603003/1
5 years, 7 months ago (2015-04-29 14:11:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 14:13:23 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 14:13:37 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/58b0023fa8dfd3b1a3216d7ce4685ceb39c7572e
Cr-Commit-Position: refs/heads/master@{#28134}

Powered by Google App Engine
This is Rietveld 408576698