Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1115573002: [chrome/browser/drive] Avoid use of MessageLoopProxy by TTRH (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
satorux1, hashimoto
CC:
chromium-reviews, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/drive module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/a2a4741fe5eb144e2971e6a4be57ceee039724bc Cr-Commit-Position: refs/heads/master@{#328742}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed Review Comments : MessageLoop postTask replacements #

Total comments: 2

Patch Set 3 : Fixed UnitTest comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -107 lines) Patch
M chrome/browser/drive/drive_uploader_unittest.cc View 1 2 28 chunks +29 lines, -28 lines 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 1 55 chunks +79 lines, -79 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-04-29 05:30:45 UTC) #2
Pranay
PTAL
5 years, 7 months ago (2015-04-30 10:17:23 UTC) #5
Pranay
satorux@chromium.org: Please review changes in chrome/browser/drive hashimoto@chromium.org: Please review changes in chrome/browser/drive
5 years, 7 months ago (2015-05-06 04:24:45 UTC) #8
hashimoto
https://codereview.chromium.org/1115573002/diff/1/chrome/browser/drive/drive_uploader_unittest.cc File chrome/browser/drive/drive_uploader_unittest.cc (right): https://codereview.chromium.org/1115573002/diff/1/chrome/browser/drive/drive_uploader_unittest.cc#newcode96 chrome/browser/drive/drive_uploader_unittest.cc:96: base::MessageLoop::current()->PostTask(FROM_HERE, While you are here, could you replace MessageLoop::current() ...
5 years, 7 months ago (2015-05-07 05:47:41 UTC) #9
Pranay
Done :) https://codereview.chromium.org/1115573002/diff/1/chrome/browser/drive/drive_uploader_unittest.cc File chrome/browser/drive/drive_uploader_unittest.cc (right): https://codereview.chromium.org/1115573002/diff/1/chrome/browser/drive/drive_uploader_unittest.cc#newcode96 chrome/browser/drive/drive_uploader_unittest.cc:96: base::MessageLoop::current()->PostTask(FROM_HERE, On 2015/05/07 05:47:40, hashimoto wrote: > ...
5 years, 7 months ago (2015-05-07 06:49:51 UTC) #10
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-07 06:50:10 UTC) #11
hashimoto
Thanks, just one point. https://codereview.chromium.org/1115573002/diff/20001/chrome/browser/drive/drive_uploader_unittest.cc File chrome/browser/drive/drive_uploader_unittest.cc (right): https://codereview.chromium.org/1115573002/diff/20001/chrome/browser/drive/drive_uploader_unittest.cc#newcode415 chrome/browser/drive/drive_uploader_unittest.cc:415: protected: Sorry for being unclear, ...
5 years, 7 months ago (2015-05-07 09:49:41 UTC) #12
Pranay
https://codereview.chromium.org/1115573002/diff/20001/chrome/browser/drive/drive_uploader_unittest.cc File chrome/browser/drive/drive_uploader_unittest.cc (right): https://codereview.chromium.org/1115573002/diff/20001/chrome/browser/drive/drive_uploader_unittest.cc#newcode415 chrome/browser/drive/drive_uploader_unittest.cc:415: protected: On 2015/05/07 09:49:41, hashimoto wrote: > Sorry for ...
5 years, 7 months ago (2015-05-07 10:01:09 UTC) #13
hashimoto
lgtm assuming all tests running properly.
5 years, 7 months ago (2015-05-07 10:02:36 UTC) #14
Pranay
Hi Hashimoto, Thanks for the review, updated the patch. Sorry i misunderstood your point :) ...
5 years, 7 months ago (2015-05-07 10:02:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1115573002/40001
5 years, 7 months ago (2015-05-07 10:03:34 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-07 11:36:59 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 11:37:55 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a2a4741fe5eb144e2971e6a4be57ceee039724bc
Cr-Commit-Position: refs/heads/master@{#328742}

Powered by Google App Engine
This is Rietveld 408576698