Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: extensions/renderer/v8_context_native_handler.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/utils_native_handler.cc ('k') | extensions/renderer/v8_schema_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/v8_context_native_handler.cc
diff --git a/extensions/renderer/v8_context_native_handler.cc b/extensions/renderer/v8_context_native_handler.cc
index 0fd538d9ec932be6bf68b3b5f75840538192e2c1..6fbc8b246b37e16cfd3382bcdc24ec1f0169be5c 100644
--- a/extensions/renderer/v8_context_native_handler.cc
+++ b/extensions/renderer/v8_context_native_handler.cc
@@ -35,7 +35,7 @@ void V8ContextNativeHandler::GetAvailability(
std::string api_name = *v8::String::Utf8Value(args[0]);
Feature::Availability availability = context_->GetAvailability(api_name);
- v8::Handle<v8::Object> ret = v8::Object::New(isolate);
+ v8::Local<v8::Object> ret = v8::Object::New(isolate);
ret->Set(v8::String::NewFromUtf8(isolate, "is_available"),
v8::Boolean::New(isolate, availability.is_available()));
ret->Set(v8::String::NewFromUtf8(isolate, "message"),
@@ -49,8 +49,8 @@ void V8ContextNativeHandler::GetModuleSystem(
const v8::FunctionCallbackInfo<v8::Value>& args) {
CHECK_EQ(args.Length(), 1);
CHECK(args[0]->IsObject());
- v8::Handle<v8::Context> v8_context =
- v8::Handle<v8::Object>::Cast(args[0])->CreationContext();
+ v8::Local<v8::Context> v8_context =
+ v8::Local<v8::Object>::Cast(args[0])->CreationContext();
ScriptContext* context =
dispatcher_->script_context_set().GetByV8Context(v8_context);
args.GetReturnValue().Set(context->module_system()->NewInstance());
@@ -60,12 +60,11 @@ void V8ContextNativeHandler::RunWithNativesEnabledModuleSystem(
const v8::FunctionCallbackInfo<v8::Value>& args) {
CHECK_EQ(args.Length(), 1);
CHECK(args[0]->IsFunction());
- v8::Handle<v8::Value> call_with_args[] = {
- context()->module_system()->NewInstance()
- };
+ v8::Local<v8::Value> call_with_args[] = {
+ context()->module_system()->NewInstance()};
ModuleSystem::NativesEnabledScope natives_enabled(context()->module_system());
- context()->CallFunction(
- v8::Handle<v8::Function>::Cast(args[0]), 1, call_with_args);
+ context()->CallFunction(v8::Local<v8::Function>::Cast(args[0]), 1,
+ call_with_args);
}
} // namespace extensions
« no previous file with comments | « extensions/renderer/utils_native_handler.cc ('k') | extensions/renderer/v8_schema_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698