Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3309)

Unified Diff: extensions/renderer/utils_native_handler.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/utils_native_handler.cc
diff --git a/extensions/renderer/utils_native_handler.cc b/extensions/renderer/utils_native_handler.cc
index a59cc7ccf26a59e9ee5c93ed1f3e3cfc9fa542f2..209069cb942d3fd74b96a63c0351b3835d5087d7 100644
--- a/extensions/renderer/utils_native_handler.cc
+++ b/extensions/renderer/utils_native_handler.cc
@@ -35,7 +35,7 @@ void UtilsNativeHandler::CreateClassWrapper(
v8::HandleScope handle_scope(GetIsolate());
// TODO(fsamuel): Consider moving the source wrapping to ModuleSystem.
- v8::Handle<v8::String> source = v8::String::NewFromUtf8(
+ v8::Local<v8::String> source = v8::String::NewFromUtf8(
GetIsolate(),
base::StringPrintf(
"(function($Object, $Function, privates, cls, superclass) {"
@@ -51,10 +51,8 @@ void UtilsNativeHandler::CreateClassWrapper(
" }\n"
" return %s;\n"
"})",
- name.c_str(),
- name.c_str(),
- name.c_str()).c_str());
- v8::Handle<v8::Value> func_as_value = context()->module_system()->RunString(
+ name.c_str(), name.c_str(), name.c_str()).c_str());
+ v8::Local<v8::Value> func_as_value = context()->module_system()->RunString(
source, v8::String::NewFromUtf8(GetIsolate(), name.c_str()));
if (func_as_value.IsEmpty() || func_as_value->IsUndefined()) {
args.GetReturnValue().SetUndefined();
@@ -62,14 +60,14 @@ void UtilsNativeHandler::CreateClassWrapper(
}
// TODO(fsamuel): Move privates from ModuleSystem to a shared location.
- v8::Handle<v8::Object> natives(context()->module_system()->NewInstance());
+ v8::Local<v8::Object> natives(context()->module_system()->NewInstance());
CHECK(!natives.IsEmpty()); // this can happen if v8 has issues
- v8::Handle<v8::Function> func = func_as_value.As<v8::Function>();
- v8::Handle<v8::Value> func_args[] = {
+ v8::Local<v8::Function> func = func_as_value.As<v8::Function>();
+ v8::Local<v8::Value> func_args[] = {
context()->safe_builtins()->GetObjekt(),
context()->safe_builtins()->GetFunction(),
- natives->Get(v8::String::NewFromUtf8(
- GetIsolate(), "privates", v8::String::kInternalizedString)),
+ natives->Get(v8::String::NewFromUtf8(GetIsolate(), "privates",
+ v8::String::kInternalizedString)),
cls,
superclass};
v8::Local<v8::Value> result;
« no previous file with comments | « extensions/renderer/user_gestures_native_handler.cc ('k') | extensions/renderer/v8_context_native_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698