Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Unified Diff: extensions/renderer/object_backed_native_handler.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/object_backed_native_handler.cc
diff --git a/extensions/renderer/object_backed_native_handler.cc b/extensions/renderer/object_backed_native_handler.cc
index 075f1d60173a6925218ccaf4fb7a7f769293a0ca..b88bf32ca4cb291c6d5cfe86a09732f229e23d67 100644
--- a/extensions/renderer/object_backed_native_handler.cc
+++ b/extensions/renderer/object_backed_native_handler.cc
@@ -28,7 +28,7 @@ ObjectBackedNativeHandler::ObjectBackedNativeHandler(ScriptContext* context)
ObjectBackedNativeHandler::~ObjectBackedNativeHandler() {
}
-v8::Handle<v8::Object> ObjectBackedNativeHandler::NewInstance() {
+v8::Local<v8::Object> ObjectBackedNativeHandler::NewInstance() {
return v8::Local<v8::ObjectTemplate>::New(GetIsolate(), object_template_)
->NewInstance();
}
@@ -37,9 +37,9 @@ v8::Handle<v8::Object> ObjectBackedNativeHandler::NewInstance() {
void ObjectBackedNativeHandler::Router(
const v8::FunctionCallbackInfo<v8::Value>& args) {
v8::HandleScope handle_scope(args.GetIsolate());
- v8::Handle<v8::Object> data = args.Data().As<v8::Object>();
+ v8::Local<v8::Object> data = args.Data().As<v8::Object>();
- v8::Handle<v8::Value> handler_function_value =
+ v8::Local<v8::Value> handler_function_value =
data->Get(v8::String::NewFromUtf8(args.GetIsolate(), kHandlerFunction));
// See comment in header file for why we do this.
if (handler_function_value.IsEmpty() ||
@@ -64,7 +64,7 @@ void ObjectBackedNativeHandler::RouteFunction(
data->Set(
v8::String::NewFromUtf8(isolate, kHandlerFunction),
v8::External::New(isolate, new HandlerFunction(handler_function)));
- v8::Handle<v8::FunctionTemplate> function_template =
+ v8::Local<v8::FunctionTemplate> function_template =
v8::FunctionTemplate::New(isolate, Router, data);
v8::Local<v8::ObjectTemplate>::New(isolate, object_template_)
->Set(isolate, name.c_str(), function_template);
@@ -81,8 +81,8 @@ void ObjectBackedNativeHandler::Invalidate() {
v8::Context::Scope context_scope(context_->v8_context());
for (size_t i = 0; i < router_data_.Size(); i++) {
- v8::Handle<v8::Object> data = router_data_.Get(i);
- v8::Handle<v8::Value> handler_function_value =
+ v8::Local<v8::Object> data = router_data_.Get(i);
+ v8::Local<v8::Value> handler_function_value =
data->Get(v8::String::NewFromUtf8(isolate, kHandlerFunction));
CHECK(!handler_function_value.IsEmpty());
delete static_cast<HandlerFunction*>(
« no previous file with comments | « extensions/renderer/object_backed_native_handler.h ('k') | extensions/renderer/render_view_observer_natives.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698