Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1937)

Unified Diff: extensions/renderer/logging_native_handler.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/logging_native_handler.h ('k') | extensions/renderer/messaging_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/logging_native_handler.cc
diff --git a/extensions/renderer/logging_native_handler.cc b/extensions/renderer/logging_native_handler.cc
index 0996a2ac67d34d4e71516c5324eb9ac67c481878..8a913a15f258af3340ea46d167300e564a5539c1 100644
--- a/extensions/renderer/logging_native_handler.cc
+++ b/extensions/renderer/logging_native_handler.cc
@@ -72,13 +72,13 @@ void LoggingNativeHandler::ParseArgs(
*error_message = "Error: " + std::string(*v8::String::Utf8Value(args[1]));
}
- v8::Handle<v8::StackTrace> stack_trace =
+ v8::Local<v8::StackTrace> stack_trace =
v8::StackTrace::CurrentStackTrace(args.GetIsolate(), 10);
if (stack_trace.IsEmpty() || stack_trace->GetFrameCount() <= 0) {
*error_message += "\n <no stack trace>";
} else {
for (size_t i = 0; i < (size_t)stack_trace->GetFrameCount(); ++i) {
- v8::Handle<v8::StackFrame> frame = stack_trace->GetFrame(i);
+ v8::Local<v8::StackFrame> frame = stack_trace->GetFrame(i);
CHECK(!frame.IsEmpty());
*error_message += base::StringPrintf(
"\n at %s (%s:%d:%d)",
@@ -91,7 +91,7 @@ void LoggingNativeHandler::ParseArgs(
}
std::string LoggingNativeHandler::ToStringOrDefault(
- const v8::Handle<v8::String>& v8_string,
+ const v8::Local<v8::String>& v8_string,
const std::string& dflt) {
if (v8_string.IsEmpty())
return dflt;
« no previous file with comments | « extensions/renderer/logging_native_handler.h ('k') | extensions/renderer/messaging_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698