Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: extensions/renderer/activity_log_converter_strategy.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/activity_log_converter_strategy.cc
diff --git a/extensions/renderer/activity_log_converter_strategy.cc b/extensions/renderer/activity_log_converter_strategy.cc
index 812b278df4b1c369ab71c28c1468ed56e3e45d88..3a8d612405562bbde78158a737b0fffc92ceed09 100644
--- a/extensions/renderer/activity_log_converter_strategy.cc
+++ b/extensions/renderer/activity_log_converter_strategy.cc
@@ -16,7 +16,7 @@ namespace {
// returns only a string with a description of the value (e.g.,
// "[HTMLElement]").
scoped_ptr<base::Value> SummarizeV8Value(v8::Isolate* isolate,
- v8::Handle<v8::Object> object) {
+ v8::Local<v8::Object> object) {
v8::TryCatch try_catch;
v8::Isolate::DisallowJavascriptExecutionScope scope(
isolate, v8::Isolate::DisallowJavascriptExecutionScope::THROW_ON_FAILURE);
@@ -25,10 +25,10 @@ scoped_ptr<base::Value> SummarizeV8Value(v8::Isolate* isolate,
name =
v8::String::Concat(name, v8::String::NewFromUtf8(isolate, "Function"));
v8::Local<v8::Value> fname =
- v8::Handle<v8::Function>::Cast(object)->GetName();
- if (fname->IsString() && v8::Handle<v8::String>::Cast(fname)->Length()) {
+ v8::Local<v8::Function>::Cast(object)->GetName();
+ if (fname->IsString() && v8::Local<v8::String>::Cast(fname)->Length()) {
name = v8::String::Concat(name, v8::String::NewFromUtf8(isolate, " "));
- name = v8::String::Concat(name, v8::Handle<v8::String>::Cast(fname));
+ name = v8::String::Concat(name, v8::Local<v8::String>::Cast(fname));
name = v8::String::Concat(name, v8::String::NewFromUtf8(isolate, "()"));
}
} else {
@@ -52,7 +52,7 @@ ActivityLogConverterStrategy::ActivityLogConverterStrategy() {}
ActivityLogConverterStrategy::~ActivityLogConverterStrategy() {}
bool ActivityLogConverterStrategy::FromV8Object(
- v8::Handle<v8::Object> value,
+ v8::Local<v8::Object> value,
base::Value** out,
v8::Isolate* isolate,
const FromV8ValueCallback& callback) const {
@@ -60,7 +60,7 @@ bool ActivityLogConverterStrategy::FromV8Object(
}
bool ActivityLogConverterStrategy::FromV8Array(
- v8::Handle<v8::Array> value,
+ v8::Local<v8::Array> value,
base::Value** out,
v8::Isolate* isolate,
const FromV8ValueCallback& callback) const {
@@ -68,7 +68,7 @@ bool ActivityLogConverterStrategy::FromV8Array(
}
bool ActivityLogConverterStrategy::FromV8Internal(
- v8::Handle<v8::Object> value,
+ v8::Local<v8::Object> value,
base::Value** out,
v8::Isolate* isolate,
const FromV8ValueCallback& callback) const {
« no previous file with comments | « extensions/renderer/activity_log_converter_strategy.h ('k') | extensions/renderer/activity_log_converter_strategy_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698