Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Side by Side Diff: extensions/renderer/utils_native_handler.cc

Issue 1115563002: extensions/renderer: Use v8::Local instead of v8::Handle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/utils_native_handler.h" 5 #include "extensions/renderer/utils_native_handler.h"
6 6
7 #include "base/strings/stringprintf.h" 7 #include "base/strings/stringprintf.h"
8 #include "extensions/renderer/script_context.h" 8 #include "extensions/renderer/script_context.h"
9 #include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h" 9 #include "third_party/WebKit/public/web/WebScopedMicrotaskSuppression.h"
10 #include "third_party/WebKit/public/web/WebSerializedScriptValue.h" 10 #include "third_party/WebKit/public/web/WebSerializedScriptValue.h"
(...skipping 17 matching lines...) Expand all
28 CHECK_EQ(3, args.Length()); 28 CHECK_EQ(3, args.Length());
29 CHECK(args[0]->IsString()); 29 CHECK(args[0]->IsString());
30 std::string name = *v8::String::Utf8Value(args[0]); 30 std::string name = *v8::String::Utf8Value(args[0]);
31 CHECK(args[1]->IsObject()); 31 CHECK(args[1]->IsObject());
32 v8::Local<v8::Object> cls = args[1].As<v8::Object>(); 32 v8::Local<v8::Object> cls = args[1].As<v8::Object>();
33 CHECK(args[2]->IsObject() || args[2]->IsUndefined()); 33 CHECK(args[2]->IsObject() || args[2]->IsUndefined());
34 v8::Local<v8::Value> superclass = args[2]; 34 v8::Local<v8::Value> superclass = args[2];
35 35
36 v8::HandleScope handle_scope(GetIsolate()); 36 v8::HandleScope handle_scope(GetIsolate());
37 // TODO(fsamuel): Consider moving the source wrapping to ModuleSystem. 37 // TODO(fsamuel): Consider moving the source wrapping to ModuleSystem.
38 v8::Handle<v8::String> source = v8::String::NewFromUtf8( 38 v8::Local<v8::String> source = v8::String::NewFromUtf8(
39 GetIsolate(), 39 GetIsolate(),
40 base::StringPrintf( 40 base::StringPrintf(
41 "(function($Object, $Function, privates, cls, superclass) {" 41 "(function($Object, $Function, privates, cls, superclass) {"
42 "'use strict';\n" 42 "'use strict';\n"
43 " function %s() {\n" 43 " function %s() {\n"
44 " var privateObj = $Object.create(cls.prototype);\n" 44 " var privateObj = $Object.create(cls.prototype);\n"
45 " $Function.apply(cls, privateObj, arguments);\n" 45 " $Function.apply(cls, privateObj, arguments);\n"
46 " privateObj.wrapper = this;\n" 46 " privateObj.wrapper = this;\n"
47 " privates(this).impl = privateObj;\n" 47 " privates(this).impl = privateObj;\n"
48 " };\n" 48 " };\n"
49 " if (superclass) {\n" 49 " if (superclass) {\n"
50 " %s.prototype = Object.create(superclass.prototype);\n" 50 " %s.prototype = Object.create(superclass.prototype);\n"
51 " }\n" 51 " }\n"
52 " return %s;\n" 52 " return %s;\n"
53 "})", 53 "})",
54 name.c_str(), 54 name.c_str(), name.c_str(), name.c_str()).c_str());
55 name.c_str(), 55 v8::Local<v8::Value> func_as_value = context()->module_system()->RunString(
56 name.c_str()).c_str());
57 v8::Handle<v8::Value> func_as_value = context()->module_system()->RunString(
58 source, v8::String::NewFromUtf8(GetIsolate(), name.c_str())); 56 source, v8::String::NewFromUtf8(GetIsolate(), name.c_str()));
59 if (func_as_value.IsEmpty() || func_as_value->IsUndefined()) { 57 if (func_as_value.IsEmpty() || func_as_value->IsUndefined()) {
60 args.GetReturnValue().SetUndefined(); 58 args.GetReturnValue().SetUndefined();
61 return; 59 return;
62 } 60 }
63 61
64 // TODO(fsamuel): Move privates from ModuleSystem to a shared location. 62 // TODO(fsamuel): Move privates from ModuleSystem to a shared location.
65 v8::Handle<v8::Object> natives(context()->module_system()->NewInstance()); 63 v8::Local<v8::Object> natives(context()->module_system()->NewInstance());
66 CHECK(!natives.IsEmpty()); // this can happen if v8 has issues 64 CHECK(!natives.IsEmpty()); // this can happen if v8 has issues
67 v8::Handle<v8::Function> func = func_as_value.As<v8::Function>(); 65 v8::Local<v8::Function> func = func_as_value.As<v8::Function>();
68 v8::Handle<v8::Value> func_args[] = { 66 v8::Local<v8::Value> func_args[] = {
69 context()->safe_builtins()->GetObjekt(), 67 context()->safe_builtins()->GetObjekt(),
70 context()->safe_builtins()->GetFunction(), 68 context()->safe_builtins()->GetFunction(),
71 natives->Get(v8::String::NewFromUtf8( 69 natives->Get(v8::String::NewFromUtf8(GetIsolate(), "privates",
72 GetIsolate(), "privates", v8::String::kInternalizedString)), 70 v8::String::kInternalizedString)),
73 cls, 71 cls,
74 superclass}; 72 superclass};
75 v8::Local<v8::Value> result; 73 v8::Local<v8::Value> result;
76 { 74 {
77 v8::TryCatch try_catch; 75 v8::TryCatch try_catch;
78 try_catch.SetCaptureMessage(true); 76 try_catch.SetCaptureMessage(true);
79 result = context()->CallFunction(func, arraysize(func_args), func_args); 77 result = context()->CallFunction(func, arraysize(func_args), func_args);
80 if (try_catch.HasCaught()) { 78 if (try_catch.HasCaught()) {
81 args.GetReturnValue().SetUndefined(); 79 args.GetReturnValue().SetUndefined();
82 return; 80 return;
83 } 81 }
84 } 82 }
85 args.GetReturnValue().Set(result); 83 args.GetReturnValue().Set(result);
86 } 84 }
87 85
88 void UtilsNativeHandler::DeepCopy( 86 void UtilsNativeHandler::DeepCopy(
89 const v8::FunctionCallbackInfo<v8::Value>& args) { 87 const v8::FunctionCallbackInfo<v8::Value>& args) {
90 CHECK_EQ(1, args.Length()); 88 CHECK_EQ(1, args.Length());
91 args.GetReturnValue().Set( 89 args.GetReturnValue().Set(
92 blink::WebSerializedScriptValue::serialize(args[0]).deserialize()); 90 blink::WebSerializedScriptValue::serialize(args[0]).deserialize());
93 } 91 }
94 92
95 } // namespace extensions 93 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/user_gestures_native_handler.cc ('k') | extensions/renderer/v8_context_native_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698